[0/4] libipa: Initialize FrameContext with ActiveState
mbox series

Message ID 20241016170348.715993-1-jacopo.mondi@ideasonboard.com
Headers show
Series
  • libipa: Initialize FrameContext with ActiveState
Related show

Message

Jacopo Mondi Oct. 16, 2024, 5:03 p.m. UTC
This series allows IPA modules to override the FrameContext initialization
to allow them to be default-initialized with the most recent algorithms' state
provided in ActiveState.

My use case is explained in detail in commit message 4/4 but I wonder if this
is useful for Paul's algorithm seeding work as well.

Jacopo Mondi (4):
  libipa: FrameContext: Move init() to FrameContext
  libipa: FCQueue: Make sure FrameContext#0 is initialized
  libipa: FCQueue: Initialize FrameContext with activeState
  ipa: rkisp1: Initialize FrameContext.agc.meteringMode

 src/ipa/ipu3/ipa_context.h        |  2 +-
 src/ipa/ipu3/ipu3.cpp             |  9 ++++--
 src/ipa/libipa/fc_queue.cpp       | 20 +++++++++++--
 src/ipa/libipa/fc_queue.h         | 48 ++++++++++++++++++++++++-------
 src/ipa/rkisp1/algorithms/agc.cpp |  2 ++
 src/ipa/rkisp1/ipa_context.cpp    | 11 +++++++
 src/ipa/rkisp1/ipa_context.h      |  5 +++-
 src/ipa/rkisp1/rkisp1.cpp         | 12 +++++---
 src/ipa/simple/ipa_context.h      |  2 +-
 src/ipa/simple/soft_simple.cpp    |  9 ++++--
 10 files changed, 93 insertions(+), 27 deletions(-)

--
2.47.0

Comments

Paul Elder Oct. 21, 2024, 3:26 a.m. UTC | #1
On Wed, Oct 16, 2024 at 07:03:41PM +0200, Jacopo Mondi wrote:
> This series allows IPA modules to override the FrameContext initialization
> to allow them to be default-initialized with the most recent algorithms' state
> provided in ActiveState.

Looks good to me.

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> 
> My use case is explained in detail in commit message 4/4 but I wonder if this
> is useful for Paul's algorithm seeding work as well.

Unfortunately my algorithm seeding work is for seeding the algorithm
between different cameras, which potentially have different sensors, so
we have to go via controls :/

> Jacopo Mondi (4):
>   libipa: FrameContext: Move init() to FrameContext
>   libipa: FCQueue: Make sure FrameContext#0 is initialized
>   libipa: FCQueue: Initialize FrameContext with activeState
>   ipa: rkisp1: Initialize FrameContext.agc.meteringMode
> 
>  src/ipa/ipu3/ipa_context.h        |  2 +-
>  src/ipa/ipu3/ipu3.cpp             |  9 ++++--
>  src/ipa/libipa/fc_queue.cpp       | 20 +++++++++++--
>  src/ipa/libipa/fc_queue.h         | 48 ++++++++++++++++++++++++-------
>  src/ipa/rkisp1/algorithms/agc.cpp |  2 ++
>  src/ipa/rkisp1/ipa_context.cpp    | 11 +++++++
>  src/ipa/rkisp1/ipa_context.h      |  5 +++-
>  src/ipa/rkisp1/rkisp1.cpp         | 12 +++++---
>  src/ipa/simple/ipa_context.h      |  2 +-
>  src/ipa/simple/soft_simple.cpp    |  9 ++++--
>  10 files changed, 93 insertions(+), 27 deletions(-)
> 
> --
> 2.47.0
>