[0/3] libcamera: rkisp1: sensorConfig assorted fixes
mbox series

Message ID 20241011092222.537322-1-umang.jain@ideasonboard.com
Headers show
Series
  • libcamera: rkisp1: sensorConfig assorted fixes
Related show

Message

Umang Jain Oct. 11, 2024, 9:22 a.m. UTC 
Assorted fixes for rkisp1, mainly pertaining to sensor configuration
plumbing.

1/3 fixes the passing of sensorConfig by using const reference.
2/3 fixes a logical error around sensorConfig and sensor format
3/3 fixes mis-ordering of forward declaration

Umang Jain (3):
  libcamera: rkisp1: Use const reference for sensor configuration
  libcamera: rkisp1: Rectify SensorConfiguration check
  libcamera: rkisp1: Maintain alphabetical order of forward declarations

 src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 4 ++--
 src/libcamera/pipeline/rkisp1/rkisp1_path.h   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Jacopo Mondi Oct. 11, 2024, 10:47 a.m. UTC | #1 
Hi Umang,

On Fri, Oct 11, 2024 at 02:52:19PM GMT, Umang Jain wrote:
> Assorted fixes for rkisp1, mainly pertaining to sensor configuration
> plumbing.
>
> 1/3 fixes the passing of sensorConfig by using const reference.
> 2/3 fixes a logical error around sensorConfig and sensor format
> 3/3 fixes mis-ordering of forward declaration

Thanks for the quick fixes
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
  j

>
> Umang Jain (3):
>   libcamera: rkisp1: Use const reference for sensor configuration
>   libcamera: rkisp1: Rectify SensorConfiguration check
>   libcamera: rkisp1: Maintain alphabetical order of forward declarations
>
>  src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 4 ++--
>  src/libcamera/pipeline/rkisp1/rkisp1_path.h   | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> --
> 2.45.2
>