[v2,0/7] Raspberry Pi: Add controls::rpi::ScalerCrops
mbox series

Message ID 20240930141415.8857-1-naush@raspberrypi.com
Headers show
Series
  • Raspberry Pi: Add controls::rpi::ScalerCrops
Related show

Message

Naushir Patuck Sept. 30, 2024, 2:14 p.m. UTC 
Hi,

Apologies for the delay in preparing the second version of this series.
Hopefully I've addressed all the feedback from the first revision, particularly:

- The rpi::ScalerCrops control is not advertised for the VC4/BCM2835 platform.
  This will only be available on the VC5/pisp platform.

- In the control documentation I've noted that this control will be a temporary
  measure until the libcamera API support per-stream controls.


The PISP implementation (available only downstream for now) still needs to
adapt to this revision, but I'll handle that once this is merged and our
downstream tree is rebased.

Thanks,
Naush

Naushir Patuck (7):
  controls: rpi: Add a vendor rpi::ScalerCrops control
  pipeline: rpi: Remove CameraData::scalerCrop_
  pipeline: rpi: Pass crop rectangle as a parameter to
    platformSetIspCrop()
  pipeline: rpi: Introduce CameraData::CropParams
  pipeline: rpi: Track which ISP output is configured for a stream
  pipeline: rpi: Pass ISP output index into platformSetIspCrop()
  pipeline: rpi: Handler controls::rpi::ScalerCrops

 src/ipa/rpi/common/ipa_base.cpp               | 14 +++
 src/libcamera/control_ids_rpi.yaml            | 21 +++++
 .../pipeline/rpi/common/pipeline_base.cpp     | 94 +++++++++++++------
 .../pipeline/rpi/common/pipeline_base.h       | 26 ++++-
 src/libcamera/pipeline/rpi/vc4/vc4.cpp        | 17 +++-
 5 files changed, 136 insertions(+), 36 deletions(-)