[0/2] apps: cam: Improve user experience with DNG capture
mbox series

Message ID 20240925152134.20284-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • apps: cam: Improve user experience with DNG capture
Related show

Message

Laurent Pinchart Sept. 25, 2024, 3:21 p.m. UTC 
Hello,

This small patch series stems from a request for help on the libcamera
IRC channel, related to DNG files produced by the cam tool that could
not be parsed by the tuning tools. It turned out that cam was compiled
without libtiff, which disabled DNG capture, and then silently captured
raw binary files instead of DNG files.

Patch 1/2 is a small cleanup, and patch 2/2 fixes the issue by producing
an error when DNG capture is requested but DNG support isn't available.

Laurent Pinchart (2):
  apps: Replace HAVE_DNG with HAVE_TIFF
  apps: cam: Print an error when outputting DNG and DNG support is
    missing

 src/apps/cam/camera_session.cpp | 15 ++++++---
 src/apps/cam/file_sink.cpp      | 60 +++++++++++++++++++++++----------
 src/apps/cam/file_sink.h        | 18 ++++++++--
 src/apps/common/dng_writer.h    |  1 -
 src/apps/qcam/main_window.cpp   |  4 +--
 5 files changed, 70 insertions(+), 28 deletions(-)


base-commit: 8bcec687344e5cc2ccef1361c03b87f0fd2cc59b