[v4,0/6] rkisp1: Add manual colour temperature control
mbox series

Message ID 20240813084451.44099-1-stefan.klug@ideasonboard.com
Headers show
Series
  • rkisp1: Add manual colour temperature control
Related show

Message

Stefan Klug Aug. 13, 2024, 8:44 a.m. UTC 
This series adds the ability to manually set the colour temperature
control. It is a partial resurrection of the "libcamera: controls:
Update the ColourTemperature control to be writable" series by David
Plowman [1], but with a implementation for the rkisp1 instead of the
rpi.

Patch 1 updates the control id documentation. Patches 2-3 implement the
control for the rkisp1. Patches 4-6 update the tuning scripts
accordingly. 

It depends on the "Two small tuning script cleanups" series [2].  Please
see the individual commit messages for more details.

Changes v1 -> v4:
- Incremented series version to v4, because technically it is a superset of [1]
- Fixed compile issue on patch 2
- Fixed typos and wording in patch 1
- Collected tags

Best regards,
Stefan

[1] https://patchwork.libcamera.org/project/libcamera/list/?series=4083 
[2] https://patchwork.libcamera.org/project/libcamera/list/?series=4484

Stefan Klug (6):
  libcamera: controls: Update the ColourTemperature control to be
    writable
  ipa: rkisp1: awb: Load white balance gains from tuning file
  ipa: rkisp1: awb: Implement ColourTemperature control
  libtuning: Modify ctt_awb.awb() so that it can run in our context
  libtuning: Add initial AWB module
  utils: tuning: rkisp1: Replace static AWB with new AWB module

 src/ipa/rkisp1/algorithms/awb.cpp             | 38 +++++++++++++
 src/ipa/rkisp1/algorithms/awb.h               |  6 ++
 src/libcamera/control_ids_core.yaml           | 24 ++++++--
 utils/tuning/libtuning/ctt_awb.py             | 55 ++++++++++---------
 .../tuning/libtuning/modules/awb/__init__.py  |  6 ++
 utils/tuning/libtuning/modules/awb/awb.py     | 42 ++++++++++++++
 utils/tuning/libtuning/modules/awb/rkisp1.py  | 27 +++++++++
 utils/tuning/rkisp1.py                        |  4 +-
 8 files changed, 170 insertions(+), 32 deletions(-)
 create mode 100644 utils/tuning/libtuning/modules/awb/__init__.py
 create mode 100644 utils/tuning/libtuning/modules/awb/awb.py
 create mode 100644 utils/tuning/libtuning/modules/awb/rkisp1.py