[libcamera-devel,v3,0/3] qcam: Fix issues in the Qt event dispatcher
mbox series

Message ID 20190930215906.1058301-1-niklas.soderlund@ragnatech.se
Headers show
Series
  • qcam: Fix issues in the Qt event dispatcher
Related show

Message

Niklas Söderlund Sept. 30, 2019, 9:59 p.m. UTC 
Hi,

While working with the IPA and testing using qcam I noticed it behaved
slightly different then cam when it came to timers. This small series
aims to align the Qt based event dispatcher of qcam with the poll based
of libcamera.

* Changes since v2
- Split v2 2/2 in two as it does two things.

* Changes since v1
- Stop timer when it's being fired to share cleanup code in
  unregisterTimer().

Niklas Söderlund (3):
  qcam: Fix unregister of not registered timer
  qcam: Stop timer on timeout
  qcam: Fix timers not emitting timeout signal

 src/qcam/qt_event_dispatcher.cpp | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Niklas Söderlund Oct. 1, 2019, 1:39 p.m. UTC | #1 
Hi,

I have pushed this series with Laurent's tags, thanks!

On 2019-09-30 23:59:03 +0200, Niklas Söderlund wrote:
> Hi,
> 
> While working with the IPA and testing using qcam I noticed it behaved
> slightly different then cam when it came to timers. This small series
> aims to align the Qt based event dispatcher of qcam with the poll based
> of libcamera.
> 
> * Changes since v2
> - Split v2 2/2 in two as it does two things.
> 
> * Changes since v1
> - Stop timer when it's being fired to share cleanup code in
>   unregisterTimer().
> 
> Niklas Söderlund (3):
>   qcam: Fix unregister of not registered timer
>   qcam: Stop timer on timeout
>   qcam: Fix timers not emitting timeout signal
> 
>  src/qcam/qt_event_dispatcher.cpp | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> -- 
> 2.23.0
>