[v6,0/2] ipa: rkisp1: Improve AGC (plumbing)
mbox series

Message ID 20240614074214.3600996-1-paul.elder@ideasonboard.com
Headers show
Series
  • ipa: rkisp1: Improve AGC (plumbing)
Related show

Message

Paul Elder June 14, 2024, 7:42 a.m. UTC 
This series adds support in the rkisp1 IPA for:
- reading histogram weights (metering modes) from tuning file
- plumbs controls for setting metering mode, exposure mode, constraint
  mode, and frame duration

As of v2, defaults have been added such that the rkisp1 pipeline will no
longer break with non-existent/erroneous tuning files.

v3 mainly adds support for both v10 and v12, and fixes a limits issue in
when using the exposure mode helper.

v4 only has minor changes.

v5 only changes PointF to the typedefed version from Vector (see the
dependent series for details).

v6 removes the piecewise linear function-ization of the luminance
target, and some more cleanups.

Paul Elder (2):
  ipa: rkisp1: agc: Read histogram weights from tuning file
  ipa: rkisp1: agc: Plumb mode-selection and frame duration controls

 src/ipa/rkisp1/algorithms/agc.cpp | 170 ++++++++++++++++++++++++++++--
 src/ipa/rkisp1/algorithms/agc.h   |   6 ++
 src/ipa/rkisp1/ipa_context.h      |  12 ++-
 3 files changed, 179 insertions(+), 9 deletions(-)

Comments

Dan Scally June 14, 2024, 8:50 a.m. UTC | #1 
Hi Paul

On 14/06/2024 08:42, Paul Elder wrote:
> This series adds support in the rkisp1 IPA for:
> - reading histogram weights (metering modes) from tuning file
> - plumbs controls for setting metering mode, exposure mode, constraint
>    mode, and frame duration
>
> As of v2, defaults have been added such that the rkisp1 pipeline will no
> longer break with non-existent/erroneous tuning files.
>
> v3 mainly adds support for both v10 and v12, and fixes a limits issue in
> when using the exposure mode helper.
>
> v4 only has minor changes.
>
> v5 only changes PointF to the typedefed version from Vector (see the
> dependent series for details).
>
> v6 removes the piecewise linear function-ization of the luminance
> target


Ooh, why? What did I miss?

> , and some more cleanups.
>
> Paul Elder (2):
>    ipa: rkisp1: agc: Read histogram weights from tuning file
>    ipa: rkisp1: agc: Plumb mode-selection and frame duration controls
>
>   src/ipa/rkisp1/algorithms/agc.cpp | 170 ++++++++++++++++++++++++++++--
>   src/ipa/rkisp1/algorithms/agc.h   |   6 ++
>   src/ipa/rkisp1/ipa_context.h      |  12 ++-
>   3 files changed, 179 insertions(+), 9 deletions(-)
>