[libcamera-devel,0/3] test: media_device: Add link handling test
mbox series

Message ID 20190111110956.14812-1-jacopo@jmondi.org
Headers show
Series
  • test: media_device: Add link handling test
Related show

Message

Jacopo Mondi Jan. 11, 2019, 11:09 a.m. UTC 
Hello,
   this three patches add test for handling links on the VIMC media graph.

Jacopo Mondi (3):
  test: media_device: Make MediaDeviceTest a MediaDevicePrintTest
  test: media_device: Add link handling test
  test: media_device: Use foreach iterator

 test/media_device/media_device_link_test.cpp  | 188 ++++++++++++++++++
 ...e_test.cpp => media_device_print_test.cpp} |  31 ++-
 test/media_device/meson.build                 |  15 +-
 3 files changed, 213 insertions(+), 21 deletions(-)
 create mode 100644 test/media_device/media_device_link_test.cpp
 rename test/media_device/{media_device_test.cpp => media_device_print_test.cpp} (79%)

--
2.20.1

Comments

Niklas Söderlund Jan. 11, 2019, 12:24 p.m. UTC | #1 
Hi Jacopo,

Thanks for your work.

On 2019-01-11 12:09:53 +0100, Jacopo Mondi wrote:
> Hello,
>    this three patches add test for handling links on the VIMC media graph.

I agree with the comments Kieran made a part from that on the test code 
itself fell free to add

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> 
> Jacopo Mondi (3):
>   test: media_device: Make MediaDeviceTest a MediaDevicePrintTest
>   test: media_device: Add link handling test
>   test: media_device: Use foreach iterator
> 
>  test/media_device/media_device_link_test.cpp  | 188 ++++++++++++++++++
>  ...e_test.cpp => media_device_print_test.cpp} |  31 ++-
>  test/media_device/meson.build                 |  15 +-
>  3 files changed, 213 insertions(+), 21 deletions(-)
>  create mode 100644 test/media_device/media_device_link_test.cpp
>  rename test/media_device/{media_device_test.cpp => media_device_print_test.cpp} (79%)
> 
> --
> 2.20.1
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel