| Message ID | 20240418124632.652163-1-dan.scally@ideasonboard.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi Dan, On Thu, Apr 18, 2024 at 01:46:29PM +0100, Daniel Scally wrote: > This series just addresses some of the things that came up in review for the > centralised AGC series but which I thought would be better to fix on top (since > they should happen regardless of that series) > > Dan > > Daniel Scally (3): > ipa: ipu3: Refer to integration time instead of shutter speed > ipa: rkisp1: Refer to integration time rather than shutter speed There are now other occurrences of shutter in the exposure mode helper. Could you rename them to integration time too ? > ipa: ipu3: Use a Y histogram instead of green > > src/ipa/ipu3/algorithms/agc.cpp | 27 ++++++++++++++------------- > src/ipa/ipu3/algorithms/agc.h | 4 ++-- > src/ipa/ipu3/ipa_context.cpp | 8 ++++---- > src/ipa/ipu3/ipa_context.h | 4 ++-- > src/ipa/ipu3/ipu3.cpp | 8 ++++---- > src/ipa/rkisp1/algorithms/agc.cpp | 4 ++-- > src/ipa/rkisp1/ipa_context.cpp | 8 ++++---- > src/ipa/rkisp1/ipa_context.h | 4 ++-- > src/ipa/rkisp1/rkisp1.cpp | 8 ++++---- > 9 files changed, 38 insertions(+), 37 deletions(-)
Hi Laurent On 08/05/2024 16:46, Laurent Pinchart wrote: > Hi Dan, > > On Thu, Apr 18, 2024 at 01:46:29PM +0100, Daniel Scally wrote: >> This series just addresses some of the things that came up in review for the >> centralised AGC series but which I thought would be better to fix on top (since >> they should happen regardless of that series) >> >> Dan >> >> Daniel Scally (3): >> ipa: ipu3: Refer to integration time instead of shutter speed >> ipa: rkisp1: Refer to integration time rather than shutter speed > There are now other occurrences of shutter in the exposure mode helper. > Could you rename them to integration time too ? Yup, will do > >> ipa: ipu3: Use a Y histogram instead of green >> >> src/ipa/ipu3/algorithms/agc.cpp | 27 ++++++++++++++------------- >> src/ipa/ipu3/algorithms/agc.h | 4 ++-- >> src/ipa/ipu3/ipa_context.cpp | 8 ++++---- >> src/ipa/ipu3/ipa_context.h | 4 ++-- >> src/ipa/ipu3/ipu3.cpp | 8 ++++---- >> src/ipa/rkisp1/algorithms/agc.cpp | 4 ++-- >> src/ipa/rkisp1/ipa_context.cpp | 8 ++++---- >> src/ipa/rkisp1/ipa_context.h | 4 ++-- >> src/ipa/rkisp1/rkisp1.cpp | 8 ++++---- >> 9 files changed, 38 insertions(+), 37 deletions(-)