[v3,00/16] Preparation for per-frame-controls and initial tests
mbox series

Message ID 20240319120517.362082-1-stefan.klug@ideasonboard.com
Headers show
  • Preparation for per-frame-controls and initial tests
Related show


Stefan Klug March 19, 2024, 12:05 p.m. UTC
  v1 errornously contained patch 08 two time and therefore didn't apply.
  - Fixed compile issues found in CI
  - Fixed style issues from reviews
  - Implemented most suggestions from reviews
    - Time sheet now uses unique_ptr
    - Time sheet uses lambdas for pixel access
    - Fixed unchecked access to vector in time sheet
    - Tests are now in a proper testsuite PerFrameControlTests
    - Replaced DelayedControls::pushForFrame() with overload for push(). I left 
      the existing semantics (without sequence) in place for now, so that the
      tests can run on both impementations
  - Fixed another corner case in delayed controls and added a test for that (12/16)
  - Reworked the big delayed controls patch into smaller patches that are easier
    to digest (4/16 - 12/16)
  - Cover letter mostly unchanged

Hi everyone,

unknowingly I stumbled into a topic that is way larger than I thought in the 
beginning. Delayed-controls and a closely related topic per-frame-controls.

I (now) know that a lot of work already went into this, noteably by 
Jacopo Mondi, David Plowman and Naushir Patuck:
Thanks for that!

I started off without per-frame-controls in mind (only delayed-controls)  
and soon realized, that these two are closely related. (It's difficult to
test delayed-controls in a real pipeline without working per-frame-controls)

To be able to tackle the whole topic in the long run I'd like to split it into parts:

1. Get a initial set of tests on mainline
I'd like to have them as a discussion basis and a reference to test against. 
These shouldn't be treated as mandatory for now (ideas on how to express that in 
code are very welcome)
- Initial lc-compliance tests for delayed-controls (and because these are system tests
 also for per-frame-controls)
- A reworked delayed controls class that hopefully makes things easier
- Tested on rkisp1

2. Get an agreement on "RaspberryPi" mode
In the previous work by David and Naushir, the (in my understanding) most prominent
requiremnet was the ability to set a control ASAP even when multiple 
requests are queued already (which makes complete sense IMHO). This requirement 
shall not get lost and I think there is a way to make it work.

3. Get the tests to pass on rkisp1, rpi and ipu3
I guess this will take a while and involve different parties, so let's not wait
until everything works everywhere...

4. Make the tests mandatory (details tbd)

This series contains part 1.

One change of thought is, that we add the ability to push requests to delayed
controls for a given sequence number and to re-push for the 
same sequence number. This has the benefit, that we don't have to decide 
early on if we operate in strict per-frame-controls mode (sometimes called 
"android mode") or in "raspberry pi" mode.

Stefan Klug (16):
  libcamera: lc-compliance: Add controls param to start() function
  libcamera: lc-compliance: Add TimeSheet class
  libcamera: lc-compliance: Add initial set of per-frame-control tests
  libcamera: delayed_controls: Update unit tests to expected semantics
  libcamera: delayed_controls: Rename class members
  libcamera: delayed_controls: Make listSize unsigned
  libcamera: delayed_controls: Add controlsAreQueued() helper
  libcamera: delayed_controls: Add ctrls list parameter to reset()
  libcamera: delayed_controls: Add sourceSequence property
  libcamera: delayed_controls: Add fillValues() helper
  libcamera: delayed_controls: Rework delayed controls implementation
  libcamera: delayed_controls: Ignore delayed request, if there is a
    newer one
  pipeline: rkisp1: Move call to setSensorControls.emit()
  pipeline: rkisp1: Add more debug logging
  pipeline: rkisp1: Fix per-frame-controls in manual mode
  pipeline: rkisp1: Apply initial controls

 include/libcamera/internal/delayed_controls.h |  25 +-
 include/libcamera/ipa/rkisp1.mojom            |   7 +-
 src/apps/lc-compliance/meson.build            |   2 +
 .../lc-compliance/per_frame_controls_test.cpp | 398 ++++++++++++++++++
 src/apps/lc-compliance/simple_capture.cpp     |   4 +-
 src/apps/lc-compliance/simple_capture.h       |   2 +-
 src/apps/lc-compliance/time_sheet.cpp         | 148 +++++++
 src/apps/lc-compliance/time_sheet.h           |  62 +++
 src/ipa/rkisp1/algorithms/agc.cpp             |   4 +-
 src/ipa/rkisp1/rkisp1.cpp                     |  49 ++-
 src/libcamera/delayed_controls.cpp            | 262 ++++++++++--
 src/libcamera/pipeline/rkisp1/rkisp1.cpp      |  11 +-
 test/delayed_controls.cpp                     | 389 ++++++++++++++---
 13 files changed, 1239 insertions(+), 124 deletions(-)
 create mode 100644 src/apps/lc-compliance/per_frame_controls_test.cpp
 create mode 100644 src/apps/lc-compliance/time_sheet.cpp
 create mode 100644 src/apps/lc-compliance/time_sheet.h