[0/2] Add 14-bit Bayer format support
mbox series

Message ID 20240305110136.3624-1-nick.hollinghurst@raspberrypi.com
Headers show
Series
  • Add 14-bit Bayer format support
Related show

Message

Nick Hollinghurst March 5, 2024, 11:01 a.m. UTC 
The following patches add 14-bit Bayer formats in v4l2_subdevice
and enable 14-bit embedded data parsing in the RPi IPA.

Nick Hollinghurst (2):
  libcamera: v4l2_subdevice: Add 14-bit Bayer formats
  ipa: rpi: cam_helper: Extend embedded data parsing to RAW14 modes

 src/ipa/rpi/cam_helper/cam_helper_imx708.cpp |  2 +-
 src/ipa/rpi/cam_helper/md_parser_smia.cpp    | 11 +++++++----
 src/libcamera/v4l2_subdevice.cpp             |  4 ++++
 3 files changed, 12 insertions(+), 5 deletions(-)

Comments

Kieran Bingham March 6, 2024, 12:52 p.m. UTC | #1 
Hi Nick,

Quoting Nick Hollinghurst (2024-03-05 11:01:34)
> The following patches add 14-bit Bayer formats in v4l2_subdevice
> and enable 14-bit embedded data parsing in the RPi IPA.
> 

It seems these patches don't apply directly as they report SBGGR16_1x16
in the context, which isn't upstream yet.

I'll handle the merge and apply already with the tags. Looks like
someone needs to handle the 16bit formats separately.

--
Kieran


> Nick Hollinghurst (2):
>   libcamera: v4l2_subdevice: Add 14-bit Bayer formats
>   ipa: rpi: cam_helper: Extend embedded data parsing to RAW14 modes
> 
>  src/ipa/rpi/cam_helper/cam_helper_imx708.cpp |  2 +-
>  src/ipa/rpi/cam_helper/md_parser_smia.cpp    | 11 +++++++----
>  src/libcamera/v4l2_subdevice.cpp             |  4 ++++
>  3 files changed, 12 insertions(+), 5 deletions(-)
> 
> -- 
> 2.30.2
>
Nick Hollinghurst March 6, 2024, 4:33 p.m. UTC | #2 
Hi Kieran,

On Wed, 6 Mar 2024 at 12:52, Kieran Bingham
<kieran.bingham@ideasonboard.com> wrote:
>
> Hi Nick,
>
> Quoting Nick Hollinghurst (2024-03-05 11:01:34)
> > The following patches add 14-bit Bayer formats in v4l2_subdevice
> > and enable 14-bit embedded data parsing in the RPi IPA.
> >
>
> It seems these patches don't apply directly as they report SBGGR16_1x16
> in the context, which isn't upstream yet.
>
> I'll handle the merge and apply already with the tags. Looks like
> someone needs to handle the 16bit formats separately.

Thank you -- I based it from the Raspberry Pi branch and I forgot to
check for applicability!

>
> --
> Kieran
>
>
> > Nick Hollinghurst (2):
> >   libcamera: v4l2_subdevice: Add 14-bit Bayer formats
> >   ipa: rpi: cam_helper: Extend embedded data parsing to RAW14 modes
> >
> >  src/ipa/rpi/cam_helper/cam_helper_imx708.cpp |  2 +-
> >  src/ipa/rpi/cam_helper/md_parser_smia.cpp    | 11 +++++++----
> >  src/libcamera/v4l2_subdevice.cpp             |  4 ++++
> >  3 files changed, 12 insertions(+), 5 deletions(-)
> >
> > --
> > 2.30.2
> >

 Nick