[RFC,0/2] libcamera: debayer_cpu: Stop requiring 2 lines of padding at the top/bottom
mbox series

Message ID 20240130181311.43745-1-hdegoede@redhat.com
Headers show
Series
  • libcamera: debayer_cpu: Stop requiring 2 lines of padding at the top/bottom
Related show

Message

Hans de Goede Jan. 30, 2024, 6:13 p.m. UTC 
Hi All,

Note this series is just FYI / a headsup about this small(ish?)
change to the SoftISP debayer code. I plan to squash this into
v3 of the SoftISP series.

Since the standard bayer pattern debayer functions now take an array
of 3 src pointers (previous-, current- and next-line) we can easily
avoid the need to have 2 lines (2 to keep the pattern unchanged)
padding at the top / bottom.

This allows the output to be 4 lines higher, which is esp. useful
with the current hi556 kernel driver which has a max-height for
the bauer data of 722 lines. So before this change it was not
possible to generate a standard 1280x720 output.

Regards,

Hans


Hans de Goede (2):
  libcamera: debayer: Move sizes() to DebayerCpu implementation
  libcamera: debayer_cpu: Stop requiring 2 lines of padding at the
    top/bottom

 .../libcamera/internal/software_isp/debayer.h | 26 +-----
 .../internal/software_isp/debayer_cpu.h       |  4 +-
 src/libcamera/software_isp/debayer_cpu.cpp    | 90 +++++++++++++++++--
 3 files changed, 86 insertions(+), 34 deletions(-)