[libcamera-devel,0/2] libcamera: Enable V4L2 subdev streams support
mbox series

Message ID 20240117144242.9903-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • libcamera: Enable V4L2 subdev streams support
Related show

Message

Laurent Pinchart Jan. 17, 2024, 2:42 p.m. UTC 
Hello,

In v6.4, new subdev ioctls were introduced to gate streams support
behind a V4L2 subdev client capability mechanism. Without enabling the
capability, the stream arguments to subdev ioctls is ignored (subdev
internal routing configuration still works, but all routes then hardcode
stream 0 on both the sink and source sides).

This small patch series updates libcamera to enable the stream
capbility. It starts by updating the kernel headers in patch 1/2
(updating to v6.4 would have been enough, but there's no reason not to
use the most recent headers), and then enables the client capability in
patch 2/2.

Laurent Pinchart (2):
  include: linux: Update kernel headers to version v6.7
  libcamera: v4l2_subdevice: Enable streams API when supported

 include/libcamera/internal/v4l2_subdevice.h |    2 +-
 include/linux/README                        |    2 +-
 include/linux/dma-buf.h                     |   84 ++
 include/linux/drm_fourcc.h                  |  128 +-
 include/linux/intel-ipu3.h                  |    7 +-
 include/linux/media-bus-format.h            |   13 +-
 include/linux/media.h                       |   29 +-
 include/linux/v4l2-common.h                 |   39 -
 include/linux/v4l2-controls.h               | 1250 ++++++++++++++++++-
 include/linux/v4l2-mediabus.h               |    4 -
 include/linux/v4l2-subdev.h                 |   56 +-
 include/linux/videodev2.h                   |   69 +-
 src/libcamera/v4l2_subdevice.cpp            |   15 +
 13 files changed, 1551 insertions(+), 147 deletions(-)


base-commit: 89227a428a82e724548399d35c98ea89566f9045

Comments

Tomi Valkeinen Jan. 17, 2024, 3:22 p.m. UTC | #1 
On 17/01/2024 16:42, Laurent Pinchart wrote:
> Hello,
> 
> In v6.4, new subdev ioctls were introduced to gate streams support
> behind a V4L2 subdev client capability mechanism. Without enabling the
> capability, the stream arguments to subdev ioctls is ignored (subdev
> internal routing configuration still works, but all routes then hardcode
> stream 0 on both the sink and source sides).
> 
> This small patch series updates libcamera to enable the stream
> capbility. It starts by updating the kernel headers in patch 1/2
> (updating to v6.4 would have been enough, but there's no reason not to
> use the most recent headers), and then enables the client capability in
> patch 2/2.
> 
> Laurent Pinchart (2):
>    include: linux: Update kernel headers to version v6.7
>    libcamera: v4l2_subdevice: Enable streams API when supported
> 
>   include/libcamera/internal/v4l2_subdevice.h |    2 +-
>   include/linux/README                        |    2 +-
>   include/linux/dma-buf.h                     |   84 ++
>   include/linux/drm_fourcc.h                  |  128 +-
>   include/linux/intel-ipu3.h                  |    7 +-
>   include/linux/media-bus-format.h            |   13 +-
>   include/linux/media.h                       |   29 +-
>   include/linux/v4l2-common.h                 |   39 -
>   include/linux/v4l2-controls.h               | 1250 ++++++++++++++++++-
>   include/linux/v4l2-mediabus.h               |    4 -
>   include/linux/v4l2-subdev.h                 |   56 +-
>   include/linux/videodev2.h                   |   69 +-
>   src/libcamera/v4l2_subdevice.cpp            |   15 +
>   13 files changed, 1551 insertions(+), 147 deletions(-)
> 
> 
> base-commit: 89227a428a82e724548399d35c98ea89566f9045

Looks good to me.

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

  Tomi