[libcamera-devel,0/2] gstreamer: Fix EOS clang build breakage
mbox series

Message ID 20231123044811.70703-1-umang.jain@ideasonboard.com
Headers show
Series
  • gstreamer: Fix EOS clang build breakage
Related show

Message

Umang Jain Nov. 23, 2023, 4:48 a.m. UTC 
The commit fd84180d7a09("gstreamer: Implement element EOS handling")
introduced a compile breakage on clang:
    
    ../../src/gstreamer/gstlibcamerasrc.cpp:768:23: error: unused variable 'oldEvent' [-Werror,-Wunused-variable]
                    g_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event);
                                        ^


Revert the patch and re-applied it with a clang pleasing fix.

Jaslo Ziska (1):
  gstreamer: Implement element EOS handling

Umang Jain (1):
  Revert "gstreamer: Implement element EOS handling"

 src/gstreamer/gstlibcamerasrc.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Laurent Pinchart Nov. 23, 2023, 7:35 a.m. UTC | #1 
Hi Umang,

Thank you for the patches.

On Thu, Nov 23, 2023 at 10:18:09AM +0530, Umang Jain via libcamera-devel wrote:
> The commit fd84180d7a09("gstreamer: Implement element EOS handling")
> introduced a compile breakage on clang:
>     
>     ../../src/gstreamer/gstlibcamerasrc.cpp:768:23: error: unused variable 'oldEvent' [-Werror,-Wunused-variable]
>                     g_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event);
>                                         ^
> 
> 
> Revert the patch and re-applied it with a clang pleasing fix.
> 
> Jaslo Ziska (1):
>   gstreamer: Implement element EOS handling
> 
> Umang Jain (1):
>   Revert "gstreamer: Implement element EOS handling"

The point of a revert is to apply it immediately to fix an urgent issue,
giving more time for the correct fix to be written. Given that no revert
has been pushed yet and the correct fix is available, let's simply fix
this without a revert.

>  src/gstreamer/gstlibcamerasrc.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)