[libcamera-devel,0/3] ipa: rpi: vc4: Add support for Arducam OV64A40
mbox series

Message ID 20231114102122.19712-1-jacopo.mondi@ideasonboard.com
Headers show
Series
  • ipa: rpi: vc4: Add support for Arducam OV64A40
Related show

Message

Jacopo Mondi Nov. 14, 2023, 10:21 a.m. UTC 
Hello,
  this small series adds support for the Arducam OV64A40 camera module to
the RaspberryPi VC4 IPA.

The first version of the driver has been published to the linux-media mailing
list and a v2 will soon follow.

Jacopo Mondi (1):
  ipa: rpi: Provide a Camera Helper for the OV64A40

Kieran Bingham (2):
  libcamera: camera_sensor: Add OV64A40 sensor properties
  ipa: rpi: vc4: Add OV64A40 tuning files

 src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp |  73 +++
 src/ipa/rpi/cam_helper/meson.build            |   1 +
 src/ipa/rpi/vc4/data/meson.build              |   1 +
 src/ipa/rpi/vc4/data/ov64a40.json             | 422 ++++++++++++++++++
 src/libcamera/camera_sensor_properties.cpp    |   4 +
 5 files changed, 501 insertions(+)
 create mode 100644 src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp
 create mode 100644 src/ipa/rpi/vc4/data/ov64a40.json

--
2.41.0

Comments

Kieran Bingham Nov. 28, 2023, 4:18 p.m. UTC | #1 
Hi Naush, David,

Do you have any feedback for this series please?

--
Regards

Kieran


Quoting Jacopo Mondi via libcamera-devel (2023-11-14 10:21:19)
> Hello,
>   this small series adds support for the Arducam OV64A40 camera module to
> the RaspberryPi VC4 IPA.
> 
> The first version of the driver has been published to the linux-media mailing
> list and a v2 will soon follow.
> 
> Jacopo Mondi (1):
>   ipa: rpi: Provide a Camera Helper for the OV64A40
> 
> Kieran Bingham (2):
>   libcamera: camera_sensor: Add OV64A40 sensor properties
>   ipa: rpi: vc4: Add OV64A40 tuning files
> 
>  src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp |  73 +++
>  src/ipa/rpi/cam_helper/meson.build            |   1 +
>  src/ipa/rpi/vc4/data/meson.build              |   1 +
>  src/ipa/rpi/vc4/data/ov64a40.json             | 422 ++++++++++++++++++
>  src/libcamera/camera_sensor_properties.cpp    |   4 +
>  5 files changed, 501 insertions(+)
>  create mode 100644 src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp
>  create mode 100644 src/ipa/rpi/vc4/data/ov64a40.json
> 
> --
> 2.41.0
>
Laurent Pinchart Nov. 28, 2023, 4:35 p.m. UTC | #2 
On Tue, Nov 14, 2023 at 11:21:19AM +0100, Jacopo Mondi via libcamera-devel wrote:
> Hello,
>   this small series adds support for the Arducam OV64A40 camera module to
> the RaspberryPi VC4 IPA.
> 
> The first version of the driver has been published to the linux-media mailing
> list and a v2 will soon follow.
> 
> Jacopo Mondi (1):
>   ipa: rpi: Provide a Camera Helper for the OV64A40
> 
> Kieran Bingham (2):
>   libcamera: camera_sensor: Add OV64A40 sensor properties
>   ipa: rpi: vc4: Add OV64A40 tuning files
> 
>  src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp |  73 +++

Can we add support for the sensor in libipa too please ?

>  src/ipa/rpi/cam_helper/meson.build            |   1 +
>  src/ipa/rpi/vc4/data/meson.build              |   1 +
>  src/ipa/rpi/vc4/data/ov64a40.json             | 422 ++++++++++++++++++
>  src/libcamera/camera_sensor_properties.cpp    |   4 +
>  5 files changed, 501 insertions(+)
>  create mode 100644 src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp
>  create mode 100644 src/ipa/rpi/vc4/data/ov64a40.json
Naushir Patuck Nov. 28, 2023, 6:46 p.m. UTC | #3 
Hi Kieran,



On Tue, 28 Nov 2023, 4:19 pm Kieran Bingham, <
kieran.bingham@ideasonboard.com> wrote:

> Hi Naush, David,
>
> Do you have any feedback for this series please?
>

Everything looks good as far as I can tell, although I don't have access to
the data sheet or a sensor to test delays, etc. out.

So for the whole series:

Reviewed-by: Naushir Patuck <naush@raspberrypi.com>


>
>
> --
> Regards
>
> Kieran
>
>
> Quoting Jacopo Mondi via libcamera-devel (2023-11-14 10:21:19)
> > Hello,
> >   this small series adds support for the Arducam OV64A40 camera module to
> > the RaspberryPi VC4 IPA.
> >
> > The first version of the driver has been published to the linux-media
> mailing
> > list and a v2 will soon follow.
> >
> > Jacopo Mondi (1):
> >   ipa: rpi: Provide a Camera Helper for the OV64A40
> >
> > Kieran Bingham (2):
> >   libcamera: camera_sensor: Add OV64A40 sensor properties
> >   ipa: rpi: vc4: Add OV64A40 tuning files
> >
> >  src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp |  73 +++
> >  src/ipa/rpi/cam_helper/meson.build            |   1 +
> >  src/ipa/rpi/vc4/data/meson.build              |   1 +
> >  src/ipa/rpi/vc4/data/ov64a40.json             | 422 ++++++++++++++++++
> >  src/libcamera/camera_sensor_properties.cpp    |   4 +
> >  5 files changed, 501 insertions(+)
> >  create mode 100644 src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp
> >  create mode 100644 src/ipa/rpi/vc4/data/ov64a40.json
> >
> > --
> > 2.41.0
> >
>