[libcamera-devel,v2,0/4] Raspberry Pi: External buffer handling
mbox series

Message ID 20230725085540.24863-1-naush@raspberrypi.com
Headers show
Series
  • Raspberry Pi: External buffer handling
Related show

Message

Naushir Patuck July 25, 2023, 8:55 a.m. UTC 
Hi,

Very minor changes in v2 to address Jacopo's comments:

1) Remove the "count" test in patch 1/4.
2) Remove the CameraData::handleExternalBuffer() declaration in patch 2/4.
3) Fix RPi::Stream() constructor for initial id value in patch 4/4.

Regards,
Naush

Naushir Patuck (4):
  pipeline: rpi: Increase buffer import count to 32
  pipeline: rpi: Remove additional external dma buf handling logic
  pipeline: rpi: Rename RPi::Stream::setExternalBuffer()
  pipeline: rpi: Simplify buffer id generation

 .../pipeline/rpi/common/pipeline_base.cpp     | 18 +------
 .../pipeline/rpi/common/pipeline_base.h       |  1 -
 .../pipeline/rpi/common/rpi_stream.cpp        | 53 +++++--------------
 .../pipeline/rpi/common/rpi_stream.h          | 48 ++---------------
 4 files changed, 17 insertions(+), 103 deletions(-)

Comments

Naushir Patuck Sept. 4, 2023, 8:20 a.m. UTC | #1 
Hi all,

Ping for another review on this please? Thanks!

Naush

On Tue, 25 Jul 2023 at 09:56, Naushir Patuck <naush@raspberrypi.com> wrote:

> Hi,
>
> Very minor changes in v2 to address Jacopo's comments:
>
> 1) Remove the "count" test in patch 1/4.
> 2) Remove the CameraData::handleExternalBuffer() declaration in patch 2/4.
> 3) Fix RPi::Stream() constructor for initial id value in patch 4/4.
>
> Regards,
> Naush
>
> Naushir Patuck (4):
>   pipeline: rpi: Increase buffer import count to 32
>   pipeline: rpi: Remove additional external dma buf handling logic
>   pipeline: rpi: Rename RPi::Stream::setExternalBuffer()
>   pipeline: rpi: Simplify buffer id generation
>
>  .../pipeline/rpi/common/pipeline_base.cpp     | 18 +------
>  .../pipeline/rpi/common/pipeline_base.h       |  1 -
>  .../pipeline/rpi/common/rpi_stream.cpp        | 53 +++++--------------
>  .../pipeline/rpi/common/rpi_stream.h          | 48 ++---------------
>  4 files changed, 17 insertions(+), 103 deletions(-)
>
> --
> 2.34.1
>
>