[libcamera-devel,v2,0/2] libcamera: Add an application to verify IPA module signatures
mbox series

Message ID 20230704234422.11863-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • libcamera: Add an application to verify IPA module signatures
Related show

Message

Laurent Pinchart July 4, 2023, 11:44 p.m. UTC 
Hello,

This small series adds a new utility, named ipa-verify, to verify
signatures of IPA modules. This is useful for packagers who want to
ensure the packaging process doesn't break signatures.

Patch 1/2 fixes a bug in the Doxygen documentation generation that
didn't take macros defined in config.h into account. Patch 2/2 then adds
the ipa-verify utility.

I would have liked to add the utility to the utils/ directory instead of
src/apps/, but that wasn't possible due to the utils/ directory being
processed by meson before src/ipa/ and src/libcamera/. I didn't
investigate alternative options much, but I can if desired.

Another thing that bothers me slightly in patch 2/2 is the addition of
the IPAManager::pubKey() function. Ideally the API exposed by internal
classes shouldn't be driven by the need of external tools. I would
probably consider it to be a bigger issue for classes exposed through
the public API, but as IPAManager is internal, it's probably not too big
of a deal.

Laurent Pinchart (2):
  Documentation: Add predefined macros from config.h to Doxyfile
  apps: Add ipa-verify application

 Documentation/Doxyfile.in                |  3 +-
 Documentation/meson.build                |  7 +++
 include/libcamera/internal/ipa_manager.h |  7 +++
 src/apps/ipa-verify/main.cpp             | 64 ++++++++++++++++++++++++
 src/apps/ipa-verify/meson.build          | 15 ++++++
 src/apps/meson.build                     |  2 +
 src/libcamera/ipa_manager.cpp            | 13 +++++
 7 files changed, 110 insertions(+), 1 deletion(-)
 create mode 100644 src/apps/ipa-verify/main.cpp
 create mode 100644 src/apps/ipa-verify/meson.build


base-commit: 8da938b00705c7bdc188174f45ee485d0880ee1e