[libcamera-devel,v1,0/4] utils: checkstyle: Add a commit message trailers checker
mbox series

Message ID 20230612224751.4437-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • utils: checkstyle: Add a commit message trailers checker
Related show

Message

Laurent Pinchart June 12, 2023, 10:47 p.m. UTC 
Hello,

This patch series originates from a discussion in the review of "[PATCH
v1 3/3] ipa: rpi: agc: Gracefully handle missing agc modes" related to
usage of git commit message trailers. It led me to realize that quite a
few issues went unnoticed through review (about 1% of all commits in the
repository). This shows, in my opinion, that humans are not great at
catching those issues. The option of fixing humans being deemed too
difficult (not to mention ethical problems), so I went for automation
instead.

Patches 1/4 to 3/4 are small improvements and cleanups to checkstyle.py,
with the main change in patch 4/4. Please see individual patches for
details. There is, in particular, information in 4/4 that may require
some discussion.

Laurent Pinchart (4):
  utils: checkstyle: Add __repr__ method to CommitFile class
  utils: checkstyle: Support running checkers selectively
  utils: checkstyle: Don't include commit ID in commit title
  utils: checkstyle: Add trailers checker

 utils/checkstyle.py | 127 +++++++++++++++++++++++++++++++++++++-------
 1 file changed, 109 insertions(+), 18 deletions(-)


base-commit: 0ee9339331c648232e87d2de2ccd5a92cc61cab2