[libcamera-devel,v1,0/3] RPi: AGC error handling
mbox series

Message ID 20230607100054.4576-1-naush@raspberrypi.com
Headers show
Series
  • RPi: AGC error handling
Related show

Message

Naushir Patuck June 7, 2023, 10 a.m. UTC 
Hi,

This patch series address an issure reported at [1] where the AGC would throw
a fatal log message and kill the application if an exposure profile was set
but the config was missing in the tuning file.

Patch 1 adds missing "short" and "long" exposure profiles to all our tunings.
Patch 2 is a small cleanup in the agc code.
Patch 3 demotes the Fatal log message to Warning when a missing profile is
requested, and uses a default profile instead.

Thanks,
Naush


[1] https://github.com/raspberrypi/libcamera/issues/59

Naushir Patuck (3):
  ipa: rpi: tunings: Add missing short and long exposure profiles
  ipa: rpi: agc: Use std::string instead of char arrays
  ipa: rpi: agc: Gracefully handle missing agc modes

 src/ipa/rpi/controller/agc_status.h        |  8 ++--
 src/ipa/rpi/controller/rpi/agc.cpp         | 53 ++++++++++++----------
 src/ipa/rpi/vc4/data/imx290.json           |  5 ++
 src/ipa/rpi/vc4/data/imx296.json           |  5 ++
 src/ipa/rpi/vc4/data/imx296_mono.json      |  5 ++
 src/ipa/rpi/vc4/data/imx378.json           |  5 ++
 src/ipa/rpi/vc4/data/imx519.json           |  5 ++
 src/ipa/rpi/vc4/data/imx708.json           |  5 ++
 src/ipa/rpi/vc4/data/imx708_noir.json      |  5 ++
 src/ipa/rpi/vc4/data/imx708_wide.json      |  5 ++
 src/ipa/rpi/vc4/data/imx708_wide_noir.json |  5 ++
 src/ipa/rpi/vc4/data/ov9281_mono.json      | 10 ++++
 src/ipa/rpi/vc4/data/se327m12.json         |  5 ++
 src/ipa/rpi/vc4/data/uncalibrated.json     | 10 ++++
 14 files changed, 103 insertions(+), 28 deletions(-)