[libcamera-devel,0/3] ipa: rkisp1: Add script to extract LSC tables from Android
mbox series

Message ID 20230306172440.57764-1-jacopo.mondi@ideasonboard.com
Headers show
Series
  • ipa: rkisp1: Add script to extract LSC tables from Android
Related show

Message

Jacopo Mondi March 6, 2023, 5:24 p.m. UTC 
Android configuration files in .xml format contain important information
among which LSC tables which can be reused for libcamera.

Add a script to extract LSC tables from Android .xml configuration files
used by the Rockchip IQ algorithm library.

With the new script extract LSC tables for the Google DRU and Pine64 Pinephone
Pro devices and add tuning files for their sensors.

Jacopo Mondi (3):
  utils: rkisp1: Add script to extract LSC tables from Android
  ipa: rkisp1: Add tuning files for Google DRU "Scarlet" sensors
  ipa: rkisp1: Add tuning files for PinephonePro sensors

 src/ipa/rkisp1/data/imx258.yaml          |  54 +++++++
 src/ipa/rkisp1/data/ov2685.yaml          |  41 +++++
 src/ipa/rkisp1/data/ov5695.yaml          |  41 +++++
 src/ipa/rkisp1/data/ov8858.yaml          |  54 +++++++
 utils/rkisp1/lsc_parse_android_config.py | 187 +++++++++++++++++++++++
 5 files changed, 377 insertions(+)
 create mode 100644 src/ipa/rkisp1/data/imx258.yaml
 create mode 100644 src/ipa/rkisp1/data/ov2685.yaml
 create mode 100644 src/ipa/rkisp1/data/ov5695.yaml
 create mode 100644 src/ipa/rkisp1/data/ov8858.yaml
 create mode 100755 utils/rkisp1/lsc_parse_android_config.py

--
2.39.0

Comments

Laurent Pinchart March 6, 2023, 5:50 p.m. UTC | #1 
Hi Jacopo,

Thank you for the patches.

On Mon, Mar 06, 2023 at 06:24:37PM +0100, Jacopo Mondi via libcamera-devel wrote:
> Android configuration files in .xml format contain important information
> among which LSC tables which can be reused for libcamera.
> 
> Add a script to extract LSC tables from Android .xml configuration files
> used by the Rockchip IQ algorithm library.
> 
> With the new script extract LSC tables for the Google DRU and Pine64 Pinephone
> Pro devices and add tuning files for their sensors.

It would be an interesting exercise to later generate LSC tables with
our tuning tool and compare the values.

> Jacopo Mondi (3):
>   utils: rkisp1: Add script to extract LSC tables from Android
>   ipa: rkisp1: Add tuning files for Google DRU "Scarlet" sensors
>   ipa: rkisp1: Add tuning files for PinephonePro sensors
> 
>  src/ipa/rkisp1/data/imx258.yaml          |  54 +++++++
>  src/ipa/rkisp1/data/ov2685.yaml          |  41 +++++
>  src/ipa/rkisp1/data/ov5695.yaml          |  41 +++++

Those two sensors should be added to the camera sensor helper.

>  src/ipa/rkisp1/data/ov8858.yaml          |  54 +++++++
>  utils/rkisp1/lsc_parse_android_config.py | 187 +++++++++++++++++++++++
>  5 files changed, 377 insertions(+)
>  create mode 100644 src/ipa/rkisp1/data/imx258.yaml
>  create mode 100644 src/ipa/rkisp1/data/ov2685.yaml
>  create mode 100644 src/ipa/rkisp1/data/ov5695.yaml
>  create mode 100644 src/ipa/rkisp1/data/ov8858.yaml
>  create mode 100755 utils/rkisp1/lsc_parse_android_config.py
Kieran Bingham March 6, 2023, 5:56 p.m. UTC | #2 
Quoting Laurent Pinchart via libcamera-devel (2023-03-06 17:50:27)
> Hi Jacopo,
> 
> Thank you for the patches.
> 
> On Mon, Mar 06, 2023 at 06:24:37PM +0100, Jacopo Mondi via libcamera-devel wrote:
> > Android configuration files in .xml format contain important information
> > among which LSC tables which can be reused for libcamera.
> > 
> > Add a script to extract LSC tables from Android .xml configuration files
> > used by the Rockchip IQ algorithm library.
> > 
> > With the new script extract LSC tables for the Google DRU and Pine64 Pinephone
> > Pro devices and add tuning files for their sensors.
> 
> It would be an interesting exercise to later generate LSC tables with
> our tuning tool and compare the values.
> 
> > Jacopo Mondi (3):
> >   utils: rkisp1: Add script to extract LSC tables from Android
> >   ipa: rkisp1: Add tuning files for Google DRU "Scarlet" sensors
> >   ipa: rkisp1: Add tuning files for PinephonePro sensors
> > 
> >  src/ipa/rkisp1/data/imx258.yaml          |  54 +++++++
> >  src/ipa/rkisp1/data/ov2685.yaml          |  41 +++++
> >  src/ipa/rkisp1/data/ov5695.yaml          |  41 +++++
> 
> Those two sensors should be added to the camera sensor helper.

Already done:

https://patchwork.libcamera.org/project/libcamera/list/?series=3773

One little RB tag and I could even merge them ;-)

--
Kieran


> 
> >  src/ipa/rkisp1/data/ov8858.yaml          |  54 +++++++
> >  utils/rkisp1/lsc_parse_android_config.py | 187 +++++++++++++++++++++++
> >  5 files changed, 377 insertions(+)
> >  create mode 100644 src/ipa/rkisp1/data/imx258.yaml
> >  create mode 100644 src/ipa/rkisp1/data/ov2685.yaml
> >  create mode 100644 src/ipa/rkisp1/data/ov5695.yaml
> >  create mode 100644 src/ipa/rkisp1/data/ov8858.yaml
> >  create mode 100755 utils/rkisp1/lsc_parse_android_config.py
> 
> -- 
> Regards,
> 
> Laurent Pinchart