[libcamera-devel,0/2] Camera/Request reliability
mbox series

Message ID 20230130180244.2150205-1-kieran.bingham@ideasonboard.com
Headers show
Series
  • Camera/Request reliability
Related show

Message

Kieran Bingham Jan. 30, 2023, 6:02 p.m. UTC
While supporting the development of Adam Pigg's Harbour-Pinhole
application, it was clear that it's too easy to submit incorrect
requests to libcamera - resulting in somewhat undefined behaviour and
then rather confusing crashes and assertions internally.

These two patches add protection to the submission of Requests objects
to a Camera.


Kieran Bingham (2):
  libcamera: camera: Ensure queued requests are prepared
  libcamera: request: A request canary

 include/libcamera/internal/request.h |  2 ++
 include/libcamera/request.h          |  4 +++
 src/libcamera/camera.cpp             | 10 ++++++
 src/libcamera/request.cpp            | 54 ++++++++++++++++++++++++++--
 4 files changed, 68 insertions(+), 2 deletions(-)