[libcamera-devel,v2,0/2] Add flicker avoidance controls
mbox series

Message ID 20230126134559.3323-1-david.plowman@raspberrypi.com
Headers show
Series
  • Add flicker avoidance controls
Related show

Message

David Plowman Jan. 26, 2023, 1:45 p.m. UTC 
Hi

v2 contains a second patch which actually implements the necessary
functionality in the RPi PH. The significant code has been in the
AEC/AGC algo all along, so there's only a bit of plumbing to do.

The first patch (which was the original one I posted) has had a couple
of small mods. The 50Hz and 60Hz modes have been renamed to Freq50Hz
and Freq60Hz, because names that start with numbers don't play nicely
with Python. Please suggest other names if you don't like those!

I also noticed an existing control called SceneFlicker which I hadn't
spotted previously. I've deleted that one because I thought they were
duplicates; the new one has more features. But if we preferred that
name we could perhaps rename the new ones to SceneFlickerMode and
SceneFlickerPeriod? Opinions welcome!

Thanks
David

David Plowman (2):
  libcamera: controls: Add controls for AEC/AGC flicker avoidance
  ipa: raspberrypi: Handle AEC/AGC flicker controls

 src/ipa/raspberrypi/raspberrypi.cpp | 80 +++++++++++++++++++++++++++++
 src/libcamera/control_ids.yaml      | 69 +++++++++++++++++++------
 2 files changed, 132 insertions(+), 17 deletions(-)