[libcamera-devel,0/5] ipa: rapsberrypi: Introduce auto-focus (auto-mode)

17929 mbox series

Introduce the auto-focus working in auto mode. This is a split-off from
https://patchwork.libcamera.org/project/libcamera/list/?series=3174
series.

The patches have been tested by me on IMX519 module with ak7375 VCM,
with mainline v6.1 **kernel.
(I'll add T-b tags manually on the list)

Only the auto mode is tested and the state machine hasn't been.
I believe that shouldn't be an issue provided there was not reviews on
the auto-focus series. If someone thinks that the state machine patches
(patch 5/10 to patch 10/10) of the parent should be bundled as well,
please speak up (it will need more testing on my end though). That
doesn't mean the state machine will not be posted / integrated - it's
just that I am not confident enough on those because I myself haven't
got a chance to try them inside out.

Samples are available at:
https://drive.google.com/drive/folders/14BKHXATZ_mZCrm27wCB5TxqTQnGmfGFq?usp=sharing

** The kernel branch comprised of unicam + bcm2835-isp driver(meant to
go upstream). Along with that IMX519 v3 patches [1] and ak7375 regulator
support [2] was cherry-pick manually. This is was the test setup to test
this series on RPi-4-Model-B.

[1]: https://lore.kernel.org/linux-media/20221116091855.00007ebd@arducam.com/
[2]: https://lore.kernel.org/linux-media/20220711144039.232196-1-y.oudjana@protonmail.com/

Jean-Michel Hautbois (4):
  ipa: raspberrypi: Introduce an autofocus algorithm
  libcamera: raspberrypi: Control the lens from pipeline
  ipa: raspberrypi: Control the lens position
  ipa: raspberrypi: Send the AF status back

Umang Jain (1):
  ipa: raspberrypi: imx519: Instantiate auto-focus algorithm

 include/libcamera/ipa/raspberrypi.mojom       |   1 +
 src/ipa/raspberrypi/controller/af_algorithm.h |  33 +++
 src/ipa/raspberrypi/controller/af_status.h    |  21 ++
 src/ipa/raspberrypi/controller/iob/af.cpp     | 212 ++++++++++++++++++
 src/ipa/raspberrypi/controller/iob/af.h       |  62 +++++
 src/ipa/raspberrypi/data/imx519.json          |   5 +-
 src/ipa/raspberrypi/meson.build               |   1 +
 src/ipa/raspberrypi/raspberrypi.cpp           |  45 +++-
 .../pipeline/raspberrypi/raspberrypi.cpp      |  17 ++
 9 files changed, 394 insertions(+), 3 deletions(-)
 create mode 100644 src/ipa/raspberrypi/controller/af_algorithm.h
 create mode 100644 src/ipa/raspberrypi/controller/af_status.h
 create mode 100644 src/ipa/raspberrypi/controller/iob/af.cpp
 create mode 100644 src/ipa/raspberrypi/controller/iob/af.h

Hi Umang,

On 01/12/2022 15:51, Umang Jain via libcamera-devel wrote:
> Introduce the auto-focus working in auto mode. This is a split-off from
> https://patchwork.libcamera.org/project/libcamera/list/?series=3174
> series.
> 
> The patches have been tested by me on IMX519 module with ak7375 VCM,
> with mainline v6.1 **kernel.
> (I'll add T-b tags manually on the list)
> 
> Only the auto mode is tested and the state machine hasn't been.
> I believe that shouldn't be an issue provided there was not reviews on
> the auto-focus series. If someone thinks that the state machine patches
> (patch 5/10 to patch 10/10) of the parent should be bundled as well,
> please speak up (it will need more testing on my end though). That
> doesn't mean the state machine will not be posted / integrated - it's
> just that I am not confident enough on those because I myself haven't
> got a chance to try them inside out.

Glad to see someone took it back :).
I can understand why you wouldn't take it it might very well need a bit 
of rework.

Thanks !

> 
> Samples are available at:
> https://drive.google.com/drive/folders/14BKHXATZ_mZCrm27wCB5TxqTQnGmfGFq?usp=sharing
> 
> ** The kernel branch comprised of unicam + bcm2835-isp driver(meant to
> go upstream). Along with that IMX519 v3 patches [1] and ak7375 regulator
> support [2] was cherry-pick manually. This is was the test setup to test
> this series on RPi-4-Model-B.
> 
> [1]: https://lore.kernel.org/linux-media/20221116091855.00007ebd@arducam.com/
> [2]: https://lore.kernel.org/linux-media/20220711144039.232196-1-y.oudjana@protonmail.com/
> 
> Jean-Michel Hautbois (4):
>    ipa: raspberrypi: Introduce an autofocus algorithm
>    libcamera: raspberrypi: Control the lens from pipeline
>    ipa: raspberrypi: Control the lens position
>    ipa: raspberrypi: Send the AF status back
> 
> Umang Jain (1):
>    ipa: raspberrypi: imx519: Instantiate auto-focus algorithm
> 
>   include/libcamera/ipa/raspberrypi.mojom       |   1 +
>   src/ipa/raspberrypi/controller/af_algorithm.h |  33 +++
>   src/ipa/raspberrypi/controller/af_status.h    |  21 ++
>   src/ipa/raspberrypi/controller/iob/af.cpp     | 212 ++++++++++++++++++
>   src/ipa/raspberrypi/controller/iob/af.h       |  62 +++++
>   src/ipa/raspberrypi/data/imx519.json          |   5 +-
>   src/ipa/raspberrypi/meson.build               |   1 +
>   src/ipa/raspberrypi/raspberrypi.cpp           |  45 +++-
>   .../pipeline/raspberrypi/raspberrypi.cpp      |  17 ++
>   9 files changed, 394 insertions(+), 3 deletions(-)
>   create mode 100644 src/ipa/raspberrypi/controller/af_algorithm.h
>   create mode 100644 src/ipa/raspberrypi/controller/af_status.h
>   create mode 100644 src/ipa/raspberrypi/controller/iob/af.cpp
>   create mode 100644 src/ipa/raspberrypi/controller/iob/af.h
>