[libcamera-devel,v2,0/5] Raspberry Pi: Generalise statistics
mbox series

Message ID 20221124103832.6172-1-naush@raspberrypi.com
Headers show
Series
  • Raspberry Pi: Generalise statistics
Related show

Message

Naushir Patuck Nov. 24, 2022, 10:38 a.m. UTC 
Hi,

Quick turn-around for v2 as we had some internal discussions on some API changes
to the RegionStats structure in patch 1/5:

1) This now uses utils::Size and utils::Point throughout.
2) The caller now provides a Region struct in set(), and gets the Region struct through
get().  This avoids the need for having more parameters in the prototype for
counted/uncounted values. In future, we will add position to the Region structure
as well.

All other patches remain functionally the same, only using the new RegionStats
API.

Thanks,
Naush

Naushir Patuck (5):
  ipa: raspberrypi: Generalise statistics
  ipa: raspberrypi: histogram: Add a constructor for an empty histogram
  ipa: raspberrypi: awb: Delay release of the statistics buffer
  ipa: raspberrypi: Use the generic statistics structure in the
    algorithms
  ipa: raspberrypi: Normalise region sums to 16-bits

 src/ipa/raspberrypi/controller/controller.h   |   4 +-
 src/ipa/raspberrypi/controller/histogram.h    |   5 +
 src/ipa/raspberrypi/controller/region_stats.h | 123 ++++++++++++++++++
 src/ipa/raspberrypi/controller/rpi/agc.cpp    |  31 ++---
 src/ipa/raspberrypi/controller/rpi/agc.h      |   2 +-
 src/ipa/raspberrypi/controller/rpi/alsc.cpp   |  32 ++---
 src/ipa/raspberrypi/controller/rpi/alsc.h     |   3 +-
 src/ipa/raspberrypi/controller/rpi/awb.cpp    |  30 ++---
 src/ipa/raspberrypi/controller/rpi/awb.h      |   1 +
 .../raspberrypi/controller/rpi/contrast.cpp   |   8 +-
 src/ipa/raspberrypi/controller/rpi/focus.cpp  |   7 +-
 src/ipa/raspberrypi/controller/rpi/lux.cpp    |  14 +-
 src/ipa/raspberrypi/raspberrypi.cpp           |  48 ++++++-
 src/ipa/raspberrypi/statistics.h              |  72 ++++++++++
 14 files changed, 304 insertions(+), 76 deletions(-)
 create mode 100644 src/ipa/raspberrypi/controller/region_stats.h
 create mode 100644 src/ipa/raspberrypi/statistics.h