[libcamera-devel,v2,0/4] ipa: Validate controls in CameraSensor
mbox series

Message ID 20221123134346.129807-1-jacopo@jmondi.org
Headers show
Series
  • ipa: Validate controls in CameraSensor
Related show

Message

Jacopo Mondi Nov. 23, 2022, 1:43 p.m. UTC 
The CameraSensor class validates that the sensor driver in use supports
the controls required for IPA modules to work correctly.
For in-tree IPA modules, whose pipeline handlers already use
CameraSensor there's no need to validate such controls again.

Move controls validation to the CameraSensor class and align the two IPA
implementations

On top of the first patch two drive-by cleanups for the RkISP1 and on
top I've collected Nicholas' patch that register FrameDurationLimits for the
RkISP1 platform.

Tested on imx8mp with the RkISP1 IPA

v1->v2:
- rebase and collect tags
- Move error message from RkISP1::configure() to RkISP1::init() in 4/4

Jacopo Mondi (3):
  libcamera: Move IPA sensor controls validation to CameraSensor
  ipa: rkisp1: Use IPAConfig in IPA::configure()
  ipa: rkisp1: Fail hard on empty CameraSensorInfo

Nicholas Roth (1):
  ipa: rkisp1: add FrameDurationLimits control

 Documentation/sensor_driver_requirements.rst |  7 ++
 include/libcamera/ipa/rkisp1.mojom           | 16 ++--
 src/ipa/ipu3/ipu3.cpp                        | 29 -------
 src/ipa/rkisp1/rkisp1.cpp                    | 91 +++++++++++++-------
 src/libcamera/camera_sensor.cpp              |  1 +
 src/libcamera/pipeline/rkisp1/rkisp1.cpp     | 28 +++---
 6 files changed, 94 insertions(+), 78 deletions(-)

--
2.38.1