[libcamera-devel,v6,0/8] Raspberry Pi AGC digital gain fixes
mbox series

Message ID 20221115090755.2921-1-naush@raspberrypi.com
Headers show
Series
  • Raspberry Pi AGC digital gain fixes
Related show

Message

Naushir Patuck Nov. 15, 2022, 9:07 a.m. UTC 
Hi,

Version 6 of this series forks DelayedControls into the Raspberry Pi pipeline
handler namespace, patches 1 and 2 cover this.  Patches 3 and 4 update the
forked DelayedControls class to add the user cookie with the same set of changes 
as were in DelayedControls in version 5 of this series.  I've removed all the
existing review tags from these two patches to give folks another chance to
validate the changes.

Thanks,
Naush

Naushir Patuck (8):
  pipeline: raspberrypi: Fork DelayedControls
  pipeline: raspberrypi: Switch to RPi::DelayedControls
  pipeline: raspberrypi: delayed_controls: Template the
    ControlRingBuffer class
  pipeline: raspberrypi: delayed_controls: Add user cookie to
    DelayedControls
  ipa: raspberrypi: Add RPiController::Metadata::mergeCopy
  ipa: raspberrypi: Use an array of RPiController::Metadata objects
  pipeline: ipa: raspberrypi: Use IPA cookies
  ipa: raspberrypi: agc: Fix digital gain calculation for manual mode

 include/libcamera/ipa/raspberrypi.mojom       |   6 +-
 src/ipa/raspberrypi/controller/metadata.h     |  10 +
 src/ipa/raspberrypi/controller/rpi/agc.cpp    |  10 +-
 src/ipa/raspberrypi/raspberrypi.cpp           | 104 ++++---
 .../pipeline/raspberrypi/delayed_controls.cpp | 293 ++++++++++++++++++
 .../pipeline/raspberrypi/delayed_controls.h   |  87 ++++++
 .../pipeline/raspberrypi/meson.build          |   1 +
 .../pipeline/raspberrypi/raspberrypi.cpp      |  26 +-
 8 files changed, 481 insertions(+), 56 deletions(-)
 create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.cpp
 create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.h

Comments

Naushir Patuck Nov. 21, 2022, 1:56 p.m. UTC | #1 
Hi,

Would I be able to get another review on this series please?

Thanks,
Naush


On Tue, 15 Nov 2022 at 09:07, Naushir Patuck <naush@raspberrypi.com> wrote:

> Hi,
>
> Version 6 of this series forks DelayedControls into the Raspberry Pi
> pipeline
> handler namespace, patches 1 and 2 cover this.  Patches 3 and 4 update the
> forked DelayedControls class to add the user cookie with the same set of
> changes
> as were in DelayedControls in version 5 of this series.  I've removed all
> the
> existing review tags from these two patches to give folks another chance to
> validate the changes.
>
> Thanks,
> Naush
>
> Naushir Patuck (8):
>   pipeline: raspberrypi: Fork DelayedControls
>   pipeline: raspberrypi: Switch to RPi::DelayedControls
>   pipeline: raspberrypi: delayed_controls: Template the
>     ControlRingBuffer class
>   pipeline: raspberrypi: delayed_controls: Add user cookie to
>     DelayedControls
>   ipa: raspberrypi: Add RPiController::Metadata::mergeCopy
>   ipa: raspberrypi: Use an array of RPiController::Metadata objects
>   pipeline: ipa: raspberrypi: Use IPA cookies
>   ipa: raspberrypi: agc: Fix digital gain calculation for manual mode
>
>  include/libcamera/ipa/raspberrypi.mojom       |   6 +-
>  src/ipa/raspberrypi/controller/metadata.h     |  10 +
>  src/ipa/raspberrypi/controller/rpi/agc.cpp    |  10 +-
>  src/ipa/raspberrypi/raspberrypi.cpp           | 104 ++++---
>  .../pipeline/raspberrypi/delayed_controls.cpp | 293 ++++++++++++++++++
>  .../pipeline/raspberrypi/delayed_controls.h   |  87 ++++++
>  .../pipeline/raspberrypi/meson.build          |   1 +
>  .../pipeline/raspberrypi/raspberrypi.cpp      |  26 +-
>  8 files changed, 481 insertions(+), 56 deletions(-)
>  create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.cpp
>  create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.h
>
> --
> 2.25.1
>
>
Naushir Patuck Nov. 25, 2022, 8:04 a.m. UTC | #2 
Hi,

Sorry to be nagging on this, but could I get another review for this series
please?
This fix needs to be in our up-coming libcamera release.

The changes to the forked version of DelayedControls are identical to what
was
in version 5.

Many thanks,
Naush


On Mon, 21 Nov 2022 at 13:56, Naushir Patuck <naush@raspberrypi.com> wrote:

> Hi,
>
> Would I be able to get another review on this series please?
>
> Thanks,
> Naush
>
>
> On Tue, 15 Nov 2022 at 09:07, Naushir Patuck <naush@raspberrypi.com>
> wrote:
>
>> Hi,
>>
>> Version 6 of this series forks DelayedControls into the Raspberry Pi
>> pipeline
>> handler namespace, patches 1 and 2 cover this.  Patches 3 and 4 update the
>> forked DelayedControls class to add the user cookie with the same set of
>> changes
>> as were in DelayedControls in version 5 of this series.  I've removed all
>> the
>> existing review tags from these two patches to give folks another chance
>> to
>> validate the changes.
>>
>> Thanks,
>> Naush
>>
>> Naushir Patuck (8):
>>   pipeline: raspberrypi: Fork DelayedControls
>>   pipeline: raspberrypi: Switch to RPi::DelayedControls
>>   pipeline: raspberrypi: delayed_controls: Template the
>>     ControlRingBuffer class
>>   pipeline: raspberrypi: delayed_controls: Add user cookie to
>>     DelayedControls
>>   ipa: raspberrypi: Add RPiController::Metadata::mergeCopy
>>   ipa: raspberrypi: Use an array of RPiController::Metadata objects
>>   pipeline: ipa: raspberrypi: Use IPA cookies
>>   ipa: raspberrypi: agc: Fix digital gain calculation for manual mode
>>
>>  include/libcamera/ipa/raspberrypi.mojom       |   6 +-
>>  src/ipa/raspberrypi/controller/metadata.h     |  10 +
>>  src/ipa/raspberrypi/controller/rpi/agc.cpp    |  10 +-
>>  src/ipa/raspberrypi/raspberrypi.cpp           | 104 ++++---
>>  .../pipeline/raspberrypi/delayed_controls.cpp | 293 ++++++++++++++++++
>>  .../pipeline/raspberrypi/delayed_controls.h   |  87 ++++++
>>  .../pipeline/raspberrypi/meson.build          |   1 +
>>  .../pipeline/raspberrypi/raspberrypi.cpp      |  26 +-
>>  8 files changed, 481 insertions(+), 56 deletions(-)
>>  create mode 100644
>> src/libcamera/pipeline/raspberrypi/delayed_controls.cpp
>>  create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.h
>>
>> --
>> 2.25.1
>>
>>