[libcamera-devel,v6,0/2] Provide framerate support for libcamerasrc
mbox series

Message ID 20221102135614.657444-1-umang.jain@ideasonboard.com
Headers show
Series
  • Provide framerate support for libcamerasrc
Related show

Message

Umang Jain Nov. 2, 2022, 1:56 p.m. UTC 
This series aims to add framerate support to libcamerasrc.
With this libcamerasrc can negotiate framerate and stream with the
requested framerate, provided that the framerate requested
is in bounds of the limits supported by the camera.

Changes in v6:
- Find divide by 0 bug, use 30fps as default fps requested
- Remove Span <> cast while populating control list
- Shorten names and reflow statement
- Simplyify error handling at a few places
- Add a few one liner comments for explaination
- fix checkstyle issues

Testing:
The series has been tested with following gst-launch-1.0

($) gst-launch-1.0 libcamerasrc ! "video/x-raw, framerate=<input>/1" !
	fpsdisplaysink

Rishikesh Donadkar (2):
  gstreamer: Do not expose the caps before configuring the camera
  gstreamer: Provide framerate support for libcamerasrc

 src/gstreamer/gstlibcamera-utils.cpp | 78 ++++++++++++++++++++++++++++
 src/gstreamer/gstlibcamera-utils.h   |  6 +++
 src/gstreamer/gstlibcamerasrc.cpp    | 34 ++++++++----
 3 files changed, 108 insertions(+), 10 deletions(-)