[libcamera-devel,v4,0/7] Raspberry Pi AGC digital gain fixes
mbox series

Message ID 20221019090107.19975-1-naush@raspberrypi.com
Headers show
Series
  • Raspberry Pi AGC digital gain fixes
Related show

Message

Naushir Patuck Oct. 19, 2022, 9:01 a.m. UTC 
Hi,

Version 4 of this series only has one change from the previous versions:

In patch 6/7, the IPA cookie (index into the RPiMetadata array) is passed from
the pipeline handler into the IPA rather than the other way around.  This helps
simplify some of our future work on per-frame-control.

There is still lots of discussion on this series to be had, particularly for
patch 1/7 where we add a cookie to DelayedControls, so feel free to provide some
feedback.

Regards,
Naush

Naushir Patuck (7):
  delayed_controls: Template the ControlRingBuffer class
  delayed_controls: Add user cookie to DelayedControls
  tests: delayed_controls: Add cookie value test
  ipa: raspberrypi: Add RPiController::Metadata::mergeCopy
  ipa: raspberrypi: Use an array of RPiController::Metadata objects
  pipeline: ipa: raspberrypi: Use IPA cookies
  ipa: raspberrypi: agc: Fix digital gain calculation for manual mode

 include/libcamera/internal/delayed_controls.h | 21 +++--
 include/libcamera/ipa/raspberrypi.mojom       |  4 +-
 src/ipa/raspberrypi/controller/metadata.h     | 10 +++
 src/ipa/raspberrypi/controller/rpi/agc.cpp    | 10 ++-
 src/ipa/raspberrypi/raspberrypi.cpp           | 82 ++++++++++++-------
 src/libcamera/delayed_controls.cpp            | 20 +++--
 src/libcamera/pipeline/ipu3/ipu3.cpp          |  3 +-
 .../pipeline/raspberrypi/raspberrypi.cpp      | 19 +++--
 src/libcamera/pipeline/rkisp1/rkisp1.cpp      |  3 +-
 test/delayed_controls.cpp                     | 52 +++++++++++-
 10 files changed, 163 insertions(+), 61 deletions(-)

Comments

Naushir Patuck Oct. 24, 2022, 7:43 a.m. UTC | #1 
Hi all,

Any chance I could get somebody to have a review on this series please?

Would it possibly help move this further if I were to revert my changes to
DelayedControls,
and add a Raspberry Pi specific implementation?

Regards,
Naush

On Wed, 19 Oct 2022 at 10:01, Naushir Patuck <naush@raspberrypi.com> wrote:

> Hi,
>
> Version 4 of this series only has one change from the previous versions:
>
> In patch 6/7, the IPA cookie (index into the RPiMetadata array) is passed
> from
> the pipeline handler into the IPA rather than the other way around.  This
> helps
> simplify some of our future work on per-frame-control.
>
> There is still lots of discussion on this series to be had, particularly
> for
> patch 1/7 where we add a cookie to DelayedControls, so feel free to
> provide some
> feedback.
>
> Regards,
> Naush
>
> Naushir Patuck (7):
>   delayed_controls: Template the ControlRingBuffer class
>   delayed_controls: Add user cookie to DelayedControls
>   tests: delayed_controls: Add cookie value test
>   ipa: raspberrypi: Add RPiController::Metadata::mergeCopy
>   ipa: raspberrypi: Use an array of RPiController::Metadata objects
>   pipeline: ipa: raspberrypi: Use IPA cookies
>   ipa: raspberrypi: agc: Fix digital gain calculation for manual mode
>
>  include/libcamera/internal/delayed_controls.h | 21 +++--
>  include/libcamera/ipa/raspberrypi.mojom       |  4 +-
>  src/ipa/raspberrypi/controller/metadata.h     | 10 +++
>  src/ipa/raspberrypi/controller/rpi/agc.cpp    | 10 ++-
>  src/ipa/raspberrypi/raspberrypi.cpp           | 82 ++++++++++++-------
>  src/libcamera/delayed_controls.cpp            | 20 +++--
>  src/libcamera/pipeline/ipu3/ipu3.cpp          |  3 +-
>  .../pipeline/raspberrypi/raspberrypi.cpp      | 19 +++--
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp      |  3 +-
>  test/delayed_controls.cpp                     | 52 +++++++++++-
>  10 files changed, 163 insertions(+), 61 deletions(-)
>
> --
> 2.25.1
>
>