[libcamera-devel,0/3] Remove redundant calls to std::string::c_str()
mbox series

Message ID 20220829185849.1884517-1-marvin.schmidt1987@gmail.com
Headers show
Series
  • Remove redundant calls to std::string::c_str()
Related show

Message

Marvin Schmidt Aug. 29, 2022, 6:58 p.m. UTC 
This is just a small series fixing three locations where std::string::c_str() is
used in a function call taking a std::string argument

Marvin Schmidt (3):
  test: camera: Remove redundant call of std::string::c_str()
  ipa: ipu3: Remove redundant call of std::string::c_str()
  ipa: rkisp1: Remove redundant call of std::string::c_str()

 src/ipa/ipu3/ipu3.cpp              | 2 +-
 src/ipa/rkisp1/rkisp1.cpp          | 2 +-
 test/camera/camera_reconfigure.cpp | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Laurent Pinchart Aug. 30, 2022, 1:13 a.m. UTC | #1 
Hi Marvin,

Thank you for the patch.

On Mon, Aug 29, 2022 at 08:58:46PM +0200, Marvin Schmidt via libcamera-devel wrote:
> This is just a small series fixing three locations where std::string::c_str() is
> used in a function call taking a std::string argument
> 
> Marvin Schmidt (3):
>   test: camera: Remove redundant call of std::string::c_str()
>   ipa: ipu3: Remove redundant call of std::string::c_str()
>   ipa: rkisp1: Remove redundant call of std::string::c_str()

For the whole series,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  src/ipa/ipu3/ipu3.cpp              | 2 +-
>  src/ipa/rkisp1/rkisp1.cpp          | 2 +-
>  test/camera/camera_reconfigure.cpp | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
Umang Jain Aug. 30, 2022, 10:30 a.m. UTC | #2 
Hello,

On 8/30/22 6:43 AM, Laurent Pinchart via libcamera-devel wrote:
> Hi Marvin,
>
> Thank you for the patch.
>
> On Mon, Aug 29, 2022 at 08:58:46PM +0200, Marvin Schmidt via libcamera-devel wrote:
>> This is just a small series fixing three locations where std::string::c_str() is
>> used in a function call taking a std::string argument
>>
>> Marvin Schmidt (3):
>>    test: camera: Remove redundant call of std::string::c_str()
>>    ipa: ipu3: Remove redundant call of std::string::c_str()
>>    ipa: rkisp1: Remove redundant call of std::string::c_str()
> For the whole series,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Same,

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
>
>>   src/ipa/ipu3/ipu3.cpp              | 2 +-
>>   src/ipa/rkisp1/rkisp1.cpp          | 2 +-
>>   test/camera/camera_reconfigure.cpp | 2 +-
>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>