[libcamera-devel,v5,0/1] Multiple colorimetry support for libcamerasrc
mbox series

Message ID 20220819065323.10051-1-rishikeshdonadkar@gmail.com
Headers show
Series
  • Multiple colorimetry support for libcamerasrc
Related show

Message

Rishikesh Donadkar Aug. 19, 2022, 6:53 a.m. UTC 
GStreamer pipeline supports passing multiple colorimetry as a comma
separated list.

For Example :

gst-launch-1.0 libcamerasrc ! "video/x-raw,colorimetry={bt2020,bt709,sRGB}" ! glimagesink

In this case, if supported by the camera one of bt2020, bt709, sRGB
should be applied.

This series aims to adds multiple colorimetry support to the libcamera
gstreamer element.

...
Based on top of [v3 PATCH 4/4] gstreamer: Provide colorimetry <> ColorSpace mappings.

https://patchwork.libcamera.org/project/libcamera/list/?series=3360
...

---
changes from v1 to v2:
- Moved the function colorspace_from_colorimetry() from PATCH 1/2 to
  PATCH 2/2.

changes from v2 to v3:
- Rebase on top of [v3 PATCH 4/4] gstreamer: Provide colorimetry <> ColorSpace mappings.
- Use the comparator utility function gst_video_colorimetry_is_equal()
  to cut down code.
- Rename dup_stream_cfg to pristine_stream_cfg.
- Log the colorimetry that is selected from the list.
- Change the API for the function gst_libcamera_configure_stream_from_caps()
  to pass pass state->config_ here instead of taking it in a holder
  variable reference.

changes from v3 to v4:
- Discard the approach form expanding the colorimetry list through caps
  normalization. Instead enumerate the colorimetry list and try out the 
  colorimetry.
- Add error checking for invalid colorimetry.

changes for v4 to v5:
- Use gboolean instead of int. Return true/false.
- Add else if for the mutually exclusive conditions.
- Add final else to trace if anything other than a string or a list is
  passed in the colorimetry field by the user.
---

Rishikesh Donadkar (1):
  gstreamer: Provide mulitple colorimetry support

 src/gstreamer/gstlibcamera-utils.cpp | 76 +++++++++++++++++++++-------
 src/gstreamer/gstlibcamera-utils.h   |  4 +-
 src/gstreamer/gstlibcamerasrc.cpp    |  2 +-
 3 files changed, 63 insertions(+), 19 deletions(-)