[libcamera-devel,v8,0/8] Introduce capture scripts to qcam
mbox series

Message ID 20220810150349.414043-1-utkarsh02t@gmail.com
Headers show
Series
  • Introduce capture scripts to qcam
Related show

Message

Utkarsh Tiwari Aug. 10, 2022, 3:03 p.m. UTC
Difference from v8:
  1. Fixes the commit message in 1/8
  2. Removes various useless headers in cam_select_dialog.h
  3. The cameraSelectDialog_ is now only created once in 6/8
  4. scriptPathLabel_ now has permanent parent captureWidget

Each patch include their differences from previous versions.

Difference from v6 :
  1. This series now merges https://lists.libcamera.org/pipermail/libcamera-devel/2022-August/033137.html
  2. The capture script button now lives in the CameraSelectorDialog
  3. We now show the capture selected scripts path
  4. Now the implementation of CameraSelectorDialog lives in it .cpp

Normal Introduction:
Hi,

This series aims to add a Dialog box which can be used to select
camera while at startup and trying to switch cameras.

The series first adds the dialog to be used just for selection of
camera at startup and then moves on to replace the current QCombBox
in favour of the dialog box.

We already got the ability to load capture scripts to run the
capture sessions in cam.

This is patch series introduces both a GUI way and a cmdline way to
load the capture script in qcam.

With this we get the ability to load a capture script and
to stop a running one.

It utilizes the parser in cam.

A Screenshot :
  https://pasteboard.co/mO811IF3RQtk.png

Utkarsh Tiwari (8):
  qcam: Use QDialog for selection of cameras at startup
  qcam: Support Hotplug for Camera Selection Dialog
  qcam: MainWindow: Replace cameraCombo_ with CameraSelectorDialog
  qcam: CamSelectDialog: Display Location and Model propety of camera
  qcam: Queue requests only through MainWindow::queueRequest()
  qcam: CamSelectDialog: Add capture script button
  qcam: CamSelectDialog: Display Capture script path
  qcam: Add --script to load capture script

 src/qcam/cam_select_dialog.cpp | 205 +++++++++++++++++++++++++++++++++
 src/qcam/cam_select_dialog.h   |  71 ++++++++++++
 src/qcam/main.cpp              |   3 +
 src/qcam/main_window.cpp       | 161 ++++++++++++++++++--------
 src/qcam/main_window.h         |  20 +++-
 src/qcam/meson.build           |   4 +
 6 files changed, 413 insertions(+), 51 deletions(-)
 create mode 100644 src/qcam/cam_select_dialog.cpp
 create mode 100644 src/qcam/cam_select_dialog.h

Comments

Utkarsh Tiwari Aug. 10, 2022, 3:35 p.m. UTC | #1
On Wed, 10 Aug, 2022, 20:33 Utkarsh Tiwari, <utkarsh02t@gmail.com> wrote:

> Difference from v8:
>
Typo :
Difference from v7:

>   1. Fixes the commit message in 1/8
>   2. Removes various useless headers in cam_select_dialog.h
>   3. The cameraSelectDialog_ is now only created once in 6/8
>   4. scriptPathLabel_ now has permanent parent captureWidget
>
> Each patch include their differences from previous versions.
>
> Difference from v6 :
>   1. This series now merges
> https://lists.libcamera.org/pipermail/libcamera-devel/2022-August/033137.html
>   2. The capture script button now lives in the CameraSelectorDialog
>   3. We now show the capture selected scripts path
>   4. Now the implementation of CameraSelectorDialog lives in it .cpp
>
> Normal Introduction:
> Hi,
>
> This series aims to add a Dialog box which can be used to select
> camera while at startup and trying to switch cameras.
>
> The series first adds the dialog to be used just for selection of
> camera at startup and then moves on to replace the current QCombBox
> in favour of the dialog box.
>
> We already got the ability to load capture scripts to run the
> capture sessions in cam.
>
> This is patch series introduces both a GUI way and a cmdline way to
> load the capture script in qcam.
>
> With this we get the ability to load a capture script and
> to stop a running one.
>
> It utilizes the parser in cam.
>
> A Screenshot :
>   https://pasteboard.co/mO811IF3RQtk.png
>
> Utkarsh Tiwari (8):
>   qcam: Use QDialog for selection of cameras at startup
>   qcam: Support Hotplug for Camera Selection Dialog
>   qcam: MainWindow: Replace cameraCombo_ with CameraSelectorDialog
>   qcam: CamSelectDialog: Display Location and Model propety of camera
>   qcam: Queue requests only through MainWindow::queueRequest()
>   qcam: CamSelectDialog: Add capture script button
>   qcam: CamSelectDialog: Display Capture script path
>   qcam: Add --script to load capture script
>
>  src/qcam/cam_select_dialog.cpp | 205 +++++++++++++++++++++++++++++++++
>  src/qcam/cam_select_dialog.h   |  71 ++++++++++++
>  src/qcam/main.cpp              |   3 +
>  src/qcam/main_window.cpp       | 161 ++++++++++++++++++--------
>  src/qcam/main_window.h         |  20 +++-
>  src/qcam/meson.build           |   4 +
>  6 files changed, 413 insertions(+), 51 deletions(-)
>  create mode 100644 src/qcam/cam_select_dialog.cpp
>  create mode 100644 src/qcam/cam_select_dialog.h
>
> --
> 2.25.1
>
>