[libcamera-devel,v5,0/9] ipa: rkisp1: Add GSL, LSC, DPCC, Filter and CProc algorithms

16848 mbox series

Hello,

This patch series combines the series "[PATCH v4 0/2] Add Filter and
Color Processing control for rkisp1" and "[PATCH v4 0/5] Add GSL, LSC
and DPCC tuning support for rkisp1" previously posted by Florian (very
conveniently both numbered v4, making this a clear v5).

The v4's were mostly fine, with just minor changes needed in "[PATCH v4
2/2] ipa: rkisp1: Add support of ColorProcessing control" that could
have been handled when applying. However, the independently developed
"[PATCH v7 01/14] libcamera: yaml_parser: Replace ok flag to get() with
std::optional" conflicts, and I would like to merge it first. v5 is thus
a rebase.

Patch 1/9 is new and adds a new variables to the utils namespace to
facilitate usage of std::optional when it stores complex types. Patch
2/9 is the YAML parser enhancement mentioned above that caused the v5,
and patch 3/9 is Florian's YamlObject::getList() implementation rebased
on 2/9 and ported to use std::optional.

After that, patches 4/9 to 9/9 are from Florian. Beside the rebase, the
only change is the minor replacement of float values with integers in
9/9.

I have left "[RFC PATCH] ipa: rkisp1: dpcc: Generalize YAML parsing" out
of the series as it still needs to be reviewed. The patch can be merged
later on top (if we decide not to drop it).

As patch 1/9 is new, it lacks a Reviewed-by tag which thus blocks the
rest of the series. Reviews would thus be appreciated :-) See patch 5/9
and 6/9 for example usages of utils::defopt.

Florian Sylvestre (7):
  libcamera: yaml_parser: Add getList() function
  include: linux: Update rkisp1 kernel header for DPCC configuration
  ipa: rkisp1: Add support of Gamma Sensor Linearization control
  ipa: rkisp1: Add support of Lens Shading Correction control
  ipa: rkisp1: Add support of Defect Pixel Cluster Correction control
  ipa: rkisp1: Add support of Filter control
  ipa: rkisp1: Add support of ColorProcessing control

Laurent Pinchart (2):
  libcamera: base: utils: Provide defopt to simplify
    std::optional::value_or() usage
  libcamera: yaml_parser: Replace ok flag to get() with std::optional

 include/libcamera/base/utils.h           |  14 ++
 include/libcamera/internal/yaml_parser.h |  25 ++-
 include/linux/rkisp1-config.h            |  77 +++++--
 src/ipa/rkisp1/algorithms/cproc.cpp      |  97 +++++++++
 src/ipa/rkisp1/algorithms/cproc.h        |  30 +++
 src/ipa/rkisp1/algorithms/dpcc.cpp       | 254 +++++++++++++++++++++++
 src/ipa/rkisp1/algorithms/dpcc.h         |  31 +++
 src/ipa/rkisp1/algorithms/filter.cpp     | 201 ++++++++++++++++++
 src/ipa/rkisp1/algorithms/filter.h       |  30 +++
 src/ipa/rkisp1/algorithms/gsl.cpp        | 149 +++++++++++++
 src/ipa/rkisp1/algorithms/gsl.h          |  34 +++
 src/ipa/rkisp1/algorithms/lsc.cpp        | 178 ++++++++++++++++
 src/ipa/rkisp1/algorithms/lsc.h          |  38 ++++
 src/ipa/rkisp1/algorithms/meson.build    |   5 +
 src/ipa/rkisp1/data/ov5640.yaml          | 147 +++++++++++++
 src/ipa/rkisp1/ipa_context.cpp           |  34 +++
 src/ipa/rkisp1/ipa_context.h             |  14 ++
 src/ipa/rkisp1/rkisp1.cpp                |   1 +
 src/libcamera/base/utils.cpp             |  21 ++
 src/libcamera/pipeline/rkisp1/rkisp1.cpp |  20 ++
 src/libcamera/yaml_parser.cpp            | 197 ++++++++++--------
 test/utils.cpp                           |  54 +++++
 test/yaml-parser.cpp                     |  77 +++----
 23 files changed, 1587 insertions(+), 141 deletions(-)
 create mode 100644 src/ipa/rkisp1/algorithms/cproc.cpp
 create mode 100644 src/ipa/rkisp1/algorithms/cproc.h
 create mode 100644 src/ipa/rkisp1/algorithms/dpcc.cpp
 create mode 100644 src/ipa/rkisp1/algorithms/dpcc.h
 create mode 100644 src/ipa/rkisp1/algorithms/filter.cpp
 create mode 100644 src/ipa/rkisp1/algorithms/filter.h
 create mode 100644 src/ipa/rkisp1/algorithms/gsl.cpp
 create mode 100644 src/ipa/rkisp1/algorithms/gsl.h
 create mode 100644 src/ipa/rkisp1/algorithms/lsc.cpp
 create mode 100644 src/ipa/rkisp1/algorithms/lsc.h


base-commit: 22ffeae04de2e7ce6b2476a35233c790beafb67f