[libcamera-devel,v5,0/2] cam: Replace dependency on SDL2_image with libjpeg
mbox series

Message ID 20220720130348.1337-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • cam: Replace dependency on SDL2_image with libjpeg
Related show

Message

Laurent Pinchart July 20, 2022, 1:03 p.m. UTC 
Hello,

This patch series bundles a new version of Eric's SDL2_image replacement
with an additional cleanup for the cam SDL support. I've numbered it v5
as Eric's patch (now 1/2) was v4, but patch 2/2 is new.

The changes in 1/2 just incorporates my review comments, I've decided to
send the result as I had already made the changes locally to test the
review recommedations.

Eric, please feel free to disagree with any of the changes :-)
Otherwise, if you're OK with them, I'll apply the series.

Eric Curtin (1):
  cam: sdl_sink: Use libjpeg over SDL2_image

Laurent Pinchart (1):
  cam: sdl_sink: Pass a Span<const uint8_t> to SDLTexture::update()

 README.rst                   |  2 +-
 src/cam/meson.build          |  8 ++--
 src/cam/sdl_sink.cpp         |  4 +-
 src/cam/sdl_texture.h        |  2 +-
 src/cam/sdl_texture_mjpg.cpp | 72 ++++++++++++++++++++++++++++++++----
 src/cam/sdl_texture_mjpg.h   |  8 +++-
 src/cam/sdl_texture_yuyv.cpp |  2 +-
 src/cam/sdl_texture_yuyv.h   |  2 +-
 8 files changed, 82 insertions(+), 18 deletions(-)


base-commit: 8b02645845bf404fba83910818b285b652f14f89

Comments

Eric Curtin July 20, 2022, 2:54 p.m. UTC | #1 
On Wed, 20 Jul 2022 at 14:04, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hello,
>
> This patch series bundles a new version of Eric's SDL2_image replacement
> with an additional cleanup for the cam SDL support. I've numbered it v5
> as Eric's patch (now 1/2) was v4, but patch 2/2 is new.
>
> The changes in 1/2 just incorporates my review comments, I've decided to
> send the result as I had already made the changes locally to test the
> review recommedations.
>
> Eric, please feel free to disagree with any of the changes :-)
> Otherwise, if you're OK with them, I'll apply the series.

I tested and reviewed the patches, all good on my end!

>
> Eric Curtin (1):
>   cam: sdl_sink: Use libjpeg over SDL2_image
>
> Laurent Pinchart (1):
>   cam: sdl_sink: Pass a Span<const uint8_t> to SDLTexture::update()
>
>  README.rst                   |  2 +-
>  src/cam/meson.build          |  8 ++--
>  src/cam/sdl_sink.cpp         |  4 +-
>  src/cam/sdl_texture.h        |  2 +-
>  src/cam/sdl_texture_mjpg.cpp | 72 ++++++++++++++++++++++++++++++++----
>  src/cam/sdl_texture_mjpg.h   |  8 +++-
>  src/cam/sdl_texture_yuyv.cpp |  2 +-
>  src/cam/sdl_texture_yuyv.h   |  2 +-
>  8 files changed, 82 insertions(+), 18 deletions(-)
>
>
> base-commit: 8b02645845bf404fba83910818b285b652f14f89
> --
> Regards,
>
> Laurent Pinchart
>
Eric Curtin July 26, 2022, 9:52 p.m. UTC | #2 
I'd add review-by tags or tested-by tags but I'm also Co-Author, would feel
wrong lol.

Just a reminder about this patch set.

On Wed 20 Jul 2022, 15:54 Eric Curtin, <ecurtin@redhat.com> wrote:

> On Wed, 20 Jul 2022 at 14:04, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> >
> > Hello,
> >
> > This patch series bundles a new version of Eric's SDL2_image replacement
> > with an additional cleanup for the cam SDL support. I've numbered it v5
> > as Eric's patch (now 1/2) was v4, but patch 2/2 is new.
> >
> > The changes in 1/2 just incorporates my review comments, I've decided to
> > send the result as I had already made the changes locally to test the
> > review recommedations.
> >
> > Eric, please feel free to disagree with any of the changes :-)
> > Otherwise, if you're OK with them, I'll apply the series.
>
> I tested and reviewed the patches, all good on my end!
>
> >
> > Eric Curtin (1):
> >   cam: sdl_sink: Use libjpeg over SDL2_image
> >
> > Laurent Pinchart (1):
> >   cam: sdl_sink: Pass a Span<const uint8_t> to SDLTexture::update()
> >
> >  README.rst                   |  2 +-
> >  src/cam/meson.build          |  8 ++--
> >  src/cam/sdl_sink.cpp         |  4 +-
> >  src/cam/sdl_texture.h        |  2 +-
> >  src/cam/sdl_texture_mjpg.cpp | 72 ++++++++++++++++++++++++++++++++----
> >  src/cam/sdl_texture_mjpg.h   |  8 +++-
> >  src/cam/sdl_texture_yuyv.cpp |  2 +-
> >  src/cam/sdl_texture_yuyv.h   |  2 +-
> >  8 files changed, 82 insertions(+), 18 deletions(-)
> >
> >
> > base-commit: 8b02645845bf404fba83910818b285b652f14f89
> > --
> > Regards,
> >
> > Laurent Pinchart
> >
>
Laurent Pinchart July 26, 2022, 10:13 p.m. UTC | #3 
Hi Eric,

On Tue, Jul 26, 2022 at 10:52:14PM +0100, Eric Curtin wrote:
> I'd add review-by tags or tested-by tags but I'm also Co-Author, would feel
> wrong lol.
> 
> Just a reminder about this patch set.

Ping for other reviewers :-)

> On Wed 20 Jul 2022, 15:54 Eric Curtin wrote:
> 
> > On Wed, 20 Jul 2022 at 14:04, Laurent Pinchart wrote:
> > >
> > > Hello,
> > >
> > > This patch series bundles a new version of Eric's SDL2_image replacement
> > > with an additional cleanup for the cam SDL support. I've numbered it v5
> > > as Eric's patch (now 1/2) was v4, but patch 2/2 is new.
> > >
> > > The changes in 1/2 just incorporates my review comments, I've decided to
> > > send the result as I had already made the changes locally to test the
> > > review recommedations.
> > >
> > > Eric, please feel free to disagree with any of the changes :-)
> > > Otherwise, if you're OK with them, I'll apply the series.
> >
> > I tested and reviewed the patches, all good on my end!
> >
> > >
> > > Eric Curtin (1):
> > >   cam: sdl_sink: Use libjpeg over SDL2_image
> > >
> > > Laurent Pinchart (1):
> > >   cam: sdl_sink: Pass a Span<const uint8_t> to SDLTexture::update()
> > >
> > >  README.rst                   |  2 +-
> > >  src/cam/meson.build          |  8 ++--
> > >  src/cam/sdl_sink.cpp         |  4 +-
> > >  src/cam/sdl_texture.h        |  2 +-
> > >  src/cam/sdl_texture_mjpg.cpp | 72 ++++++++++++++++++++++++++++++++----
> > >  src/cam/sdl_texture_mjpg.h   |  8 +++-
> > >  src/cam/sdl_texture_yuyv.cpp |  2 +-
> > >  src/cam/sdl_texture_yuyv.h   |  2 +-
> > >  8 files changed, 82 insertions(+), 18 deletions(-)
> > >
> > >
> > > base-commit: 8b02645845bf404fba83910818b285b652f14f89
Eric Curtin July 28, 2022, 7 a.m. UTC | #4 
@Kieran Bingham and @Ian Mullins

If you get a spare moment, would you like to do a quick review?

Is mise le meas/Regards,

Eric Curtin


On Tue, 26 Jul 2022 at 23:14, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Eric,
>
> On Tue, Jul 26, 2022 at 10:52:14PM +0100, Eric Curtin wrote:
> > I'd add review-by tags or tested-by tags but I'm also Co-Author, would feel
> > wrong lol.
> >
> > Just a reminder about this patch set.
>
> Ping for other reviewers :-)
>
> > On Wed 20 Jul 2022, 15:54 Eric Curtin wrote:
> >
> > > On Wed, 20 Jul 2022 at 14:04, Laurent Pinchart wrote:
> > > >
> > > > Hello,
> > > >
> > > > This patch series bundles a new version of Eric's SDL2_image replacement
> > > > with an additional cleanup for the cam SDL support. I've numbered it v5
> > > > as Eric's patch (now 1/2) was v4, but patch 2/2 is new.
> > > >
> > > > The changes in 1/2 just incorporates my review comments, I've decided to
> > > > send the result as I had already made the changes locally to test the
> > > > review recommedations.
> > > >
> > > > Eric, please feel free to disagree with any of the changes :-)
> > > > Otherwise, if you're OK with them, I'll apply the series.
> > >
> > > I tested and reviewed the patches, all good on my end!
> > >
> > > >
> > > > Eric Curtin (1):
> > > >   cam: sdl_sink: Use libjpeg over SDL2_image
> > > >
> > > > Laurent Pinchart (1):
> > > >   cam: sdl_sink: Pass a Span<const uint8_t> to SDLTexture::update()
> > > >
> > > >  README.rst                   |  2 +-
> > > >  src/cam/meson.build          |  8 ++--
> > > >  src/cam/sdl_sink.cpp         |  4 +-
> > > >  src/cam/sdl_texture.h        |  2 +-
> > > >  src/cam/sdl_texture_mjpg.cpp | 72 ++++++++++++++++++++++++++++++++----
> > > >  src/cam/sdl_texture_mjpg.h   |  8 +++-
> > > >  src/cam/sdl_texture_yuyv.cpp |  2 +-
> > > >  src/cam/sdl_texture_yuyv.h   |  2 +-
> > > >  8 files changed, 82 insertions(+), 18 deletions(-)
> > > >
> > > >
> > > > base-commit: 8b02645845bf404fba83910818b285b652f14f89
>
> --
> Regards,
>
> Laurent Pinchart
>
Laurent Pinchart July 28, 2022, 11:32 a.m. UTC | #5 
Hi Eric,

On Thu, Jul 28, 2022 at 08:00:11AM +0100, Eric Curtin wrote:
> @Kieran Bingham and @Ian Mullins
> 
> If you get a spare moment, would you like to do a quick review?

Jacopo has reviewed the patches (thanks !), I've now pushed them.

> On Tue, 26 Jul 2022 at 23:14, Laurent Pinchart wrote:
> > On Tue, Jul 26, 2022 at 10:52:14PM +0100, Eric Curtin wrote:
> > > I'd add review-by tags or tested-by tags but I'm also Co-Author, would feel
> > > wrong lol.
> > >
> > > Just a reminder about this patch set.
> >
> > Ping for other reviewers :-)
> >
> > > On Wed 20 Jul 2022, 15:54 Eric Curtin wrote:
> > >
> > > > On Wed, 20 Jul 2022 at 14:04, Laurent Pinchart wrote:
> > > > >
> > > > > Hello,
> > > > >
> > > > > This patch series bundles a new version of Eric's SDL2_image replacement
> > > > > with an additional cleanup for the cam SDL support. I've numbered it v5
> > > > > as Eric's patch (now 1/2) was v4, but patch 2/2 is new.
> > > > >
> > > > > The changes in 1/2 just incorporates my review comments, I've decided to
> > > > > send the result as I had already made the changes locally to test the
> > > > > review recommedations.
> > > > >
> > > > > Eric, please feel free to disagree with any of the changes :-)
> > > > > Otherwise, if you're OK with them, I'll apply the series.
> > > >
> > > > I tested and reviewed the patches, all good on my end!
> > > >
> > > > >
> > > > > Eric Curtin (1):
> > > > >   cam: sdl_sink: Use libjpeg over SDL2_image
> > > > >
> > > > > Laurent Pinchart (1):
> > > > >   cam: sdl_sink: Pass a Span<const uint8_t> to SDLTexture::update()
> > > > >
> > > > >  README.rst                   |  2 +-
> > > > >  src/cam/meson.build          |  8 ++--
> > > > >  src/cam/sdl_sink.cpp         |  4 +-
> > > > >  src/cam/sdl_texture.h        |  2 +-
> > > > >  src/cam/sdl_texture_mjpg.cpp | 72 ++++++++++++++++++++++++++++++++----
> > > > >  src/cam/sdl_texture_mjpg.h   |  8 +++-
> > > > >  src/cam/sdl_texture_yuyv.cpp |  2 +-
> > > > >  src/cam/sdl_texture_yuyv.h   |  2 +-
> > > > >  8 files changed, 82 insertions(+), 18 deletions(-)
> > > > >
> > > > >
> > > > > base-commit: 8b02645845bf404fba83910818b285b652f14f89