| Message ID | 20220715143822.672321-1-chenghaoyang@google.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hello folks, It's been a while since the last update. If there's no other dispute, may we merge the series of patches recently? Thanks! On Fri, Jul 15, 2022 at 11:38 PM Harvey Yang <chenghaoyang@chromium.org> wrote: > Hi all, > > Fixed thumbnail buffer issue. > > Please help review and merge them if possible :) > Thanks! > > BR, > Harvey > > Harvey Yang (6): > Allow inheritance of FrameBuffer > Add HALFrameBuffer and replace FrameBuffer in src/android > Add meson.build in src/android/jpeg > Move generateThumbnail from PostProcessorJpeg to Encoder > Pass StreamBuffer to Encoder::encoder > Add JEA implementation > > include/libcamera/framebuffer.h | 3 +- > src/android/camera_device.cpp | 3 +- > src/android/cros/camera3_hal.cpp | 2 + > src/android/cros_mojo_token.h | 12 ++ > src/android/frame_buffer_allocator.h | 7 +- > src/android/hal_framebuffer.cpp | 23 +++ > src/android/hal_framebuffer.h | 27 ++++ > src/android/jpeg/encoder.h | 10 +- > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++ > src/android/jpeg/encoder_jea.h | 35 +++++ > src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++---- > src/android/jpeg/encoder_libjpeg.h | 33 ++++- > src/android/jpeg/meson.build | 16 +++ > src/android/jpeg/post_processor_jpeg.cpp | 65 ++------- > src/android/jpeg/post_processor_jpeg.h | 11 +- > src/android/meson.build | 6 +- > .../mm/cros_frame_buffer_allocator.cpp | 14 +- > .../mm/generic_frame_buffer_allocator.cpp | 12 +- > 18 files changed, 391 insertions(+), 114 deletions(-) > create mode 100644 src/android/cros_mojo_token.h > create mode 100644 src/android/hal_framebuffer.cpp > create mode 100644 src/android/hal_framebuffer.h > create mode 100644 src/android/jpeg/encoder_jea.cpp > create mode 100644 src/android/jpeg/encoder_jea.h > create mode 100644 src/android/jpeg/meson.build > > -- > 2.37.0.170.g444d1eabd0-goog > >
Quoting Cheng-Hao Yang via libcamera-devel (2022-11-01 04:53:10) > Hello folks, > > It's been a while since the last update. If there's no other dispute, may > we merge the series of patches recently? > Thanks! As this is the android layer - is there anyone at Google/Chromium who can do a review on this series ? -- Kieran > On Fri, Jul 15, 2022 at 11:38 PM Harvey Yang <chenghaoyang@chromium.org> > wrote: > > > Hi all, > > > > Fixed thumbnail buffer issue. > > > > Please help review and merge them if possible :) > > Thanks! > > > > BR, > > Harvey > > > > Harvey Yang (6): > > Allow inheritance of FrameBuffer > > Add HALFrameBuffer and replace FrameBuffer in src/android > > Add meson.build in src/android/jpeg > > Move generateThumbnail from PostProcessorJpeg to Encoder > > Pass StreamBuffer to Encoder::encoder > > Add JEA implementation > > > > include/libcamera/framebuffer.h | 3 +- > > src/android/camera_device.cpp | 3 +- > > src/android/cros/camera3_hal.cpp | 2 + > > src/android/cros_mojo_token.h | 12 ++ > > src/android/frame_buffer_allocator.h | 7 +- > > src/android/hal_framebuffer.cpp | 23 +++ > > src/android/hal_framebuffer.h | 27 ++++ > > src/android/jpeg/encoder.h | 10 +- > > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++ > > src/android/jpeg/encoder_jea.h | 35 +++++ > > src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++---- > > src/android/jpeg/encoder_libjpeg.h | 33 ++++- > > src/android/jpeg/meson.build | 16 +++ > > src/android/jpeg/post_processor_jpeg.cpp | 65 ++------- > > src/android/jpeg/post_processor_jpeg.h | 11 +- > > src/android/meson.build | 6 +- > > .../mm/cros_frame_buffer_allocator.cpp | 14 +- > > .../mm/generic_frame_buffer_allocator.cpp | 12 +- > > 18 files changed, 391 insertions(+), 114 deletions(-) > > create mode 100644 src/android/cros_mojo_token.h > > create mode 100644 src/android/hal_framebuffer.cpp > > create mode 100644 src/android/hal_framebuffer.h > > create mode 100644 src/android/jpeg/encoder_jea.cpp > > create mode 100644 src/android/jpeg/encoder_jea.h > > create mode 100644 src/android/jpeg/meson.build > > > > -- > > 2.37.0.170.g444d1eabd0-goog > > > >
Hi Han-lin, Could you do the final review, and let Kieran or Laurent help to merge the patches? Thanks! On Thu, Nov 24, 2022 at 10:03 PM Kieran Bingham < kieran.bingham@ideasonboard.com> wrote: > Quoting Cheng-Hao Yang via libcamera-devel (2022-11-01 04:53:10) > > Hello folks, > > > > It's been a while since the last update. If there's no other dispute, may > > we merge the series of patches recently? > > Thanks! > > As this is the android layer - is there anyone at Google/Chromium who > can do a review on this series ? > > -- > Kieran > > > > On Fri, Jul 15, 2022 at 11:38 PM Harvey Yang <chenghaoyang@chromium.org> > > wrote: > > > > > Hi all, > > > > > > Fixed thumbnail buffer issue. > > > > > > Please help review and merge them if possible :) > > > Thanks! > > > > > > BR, > > > Harvey > > > > > > Harvey Yang (6): > > > Allow inheritance of FrameBuffer > > > Add HALFrameBuffer and replace FrameBuffer in src/android > > > Add meson.build in src/android/jpeg > > > Move generateThumbnail from PostProcessorJpeg to Encoder > > > Pass StreamBuffer to Encoder::encoder > > > Add JEA implementation > > > > > > include/libcamera/framebuffer.h | 3 +- > > > src/android/camera_device.cpp | 3 +- > > > src/android/cros/camera3_hal.cpp | 2 + > > > src/android/cros_mojo_token.h | 12 ++ > > > src/android/frame_buffer_allocator.h | 7 +- > > > src/android/hal_framebuffer.cpp | 23 +++ > > > src/android/hal_framebuffer.h | 27 ++++ > > > src/android/jpeg/encoder.h | 10 +- > > > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++ > > > src/android/jpeg/encoder_jea.h | 35 +++++ > > > src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++---- > > > src/android/jpeg/encoder_libjpeg.h | 33 ++++- > > > src/android/jpeg/meson.build | 16 +++ > > > src/android/jpeg/post_processor_jpeg.cpp | 65 ++------- > > > src/android/jpeg/post_processor_jpeg.h | 11 +- > > > src/android/meson.build | 6 +- > > > .../mm/cros_frame_buffer_allocator.cpp | 14 +- > > > .../mm/generic_frame_buffer_allocator.cpp | 12 +- > > > 18 files changed, 391 insertions(+), 114 deletions(-) > > > create mode 100644 src/android/cros_mojo_token.h > > > create mode 100644 src/android/hal_framebuffer.cpp > > > create mode 100644 src/android/hal_framebuffer.h > > > create mode 100644 src/android/jpeg/encoder_jea.cpp > > > create mode 100644 src/android/jpeg/encoder_jea.h > > > create mode 100644 src/android/jpeg/meson.build > > > > > > -- > > > 2.37.0.170.g444d1eabd0-goog > > > > > > >
Sorry I missed this mail. It looks good to me :) Thanks for the patch! Reviewed-by: Han-Lin Chen <hanlinchen@chromium.org> On Fri, Nov 25, 2022 at 1:28 PM Cheng-Hao Yang <chenghaoyang@chromium.org> wrote: > > Hi Han-lin, > > Could you do the final review, and let Kieran or Laurent help to merge the patches? > Thanks! > > On Thu, Nov 24, 2022 at 10:03 PM Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: >> >> Quoting Cheng-Hao Yang via libcamera-devel (2022-11-01 04:53:10) >> > Hello folks, >> > >> > It's been a while since the last update. If there's no other dispute, may >> > we merge the series of patches recently? >> > Thanks! >> >> As this is the android layer - is there anyone at Google/Chromium who >> can do a review on this series ? >> >> -- >> Kieran >> >> >> > On Fri, Jul 15, 2022 at 11:38 PM Harvey Yang <chenghaoyang@chromium.org> >> > wrote: >> > >> > > Hi all, >> > > >> > > Fixed thumbnail buffer issue. >> > > >> > > Please help review and merge them if possible :) >> > > Thanks! >> > > >> > > BR, >> > > Harvey >> > > >> > > Harvey Yang (6): >> > > Allow inheritance of FrameBuffer >> > > Add HALFrameBuffer and replace FrameBuffer in src/android >> > > Add meson.build in src/android/jpeg >> > > Move generateThumbnail from PostProcessorJpeg to Encoder >> > > Pass StreamBuffer to Encoder::encoder >> > > Add JEA implementation >> > > >> > > include/libcamera/framebuffer.h | 3 +- >> > > src/android/camera_device.cpp | 3 +- >> > > src/android/cros/camera3_hal.cpp | 2 + >> > > src/android/cros_mojo_token.h | 12 ++ >> > > src/android/frame_buffer_allocator.h | 7 +- >> > > src/android/hal_framebuffer.cpp | 23 +++ >> > > src/android/hal_framebuffer.h | 27 ++++ >> > > src/android/jpeg/encoder.h | 10 +- >> > > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++ >> > > src/android/jpeg/encoder_jea.h | 35 +++++ >> > > src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++---- >> > > src/android/jpeg/encoder_libjpeg.h | 33 ++++- >> > > src/android/jpeg/meson.build | 16 +++ >> > > src/android/jpeg/post_processor_jpeg.cpp | 65 ++------- >> > > src/android/jpeg/post_processor_jpeg.h | 11 +- >> > > src/android/meson.build | 6 +- >> > > .../mm/cros_frame_buffer_allocator.cpp | 14 +- >> > > .../mm/generic_frame_buffer_allocator.cpp | 12 +- >> > > 18 files changed, 391 insertions(+), 114 deletions(-) >> > > create mode 100644 src/android/cros_mojo_token.h >> > > create mode 100644 src/android/hal_framebuffer.cpp >> > > create mode 100644 src/android/hal_framebuffer.h >> > > create mode 100644 src/android/jpeg/encoder_jea.cpp >> > > create mode 100644 src/android/jpeg/encoder_jea.h >> > > create mode 100644 src/android/jpeg/meson.build >> > > >> > > -- >> > > 2.37.0.170.g444d1eabd0-goog >> > > >> > >