[libcamera-devel,v2,0/4] Add colorimetry support to libcamera gstreamer element.
mbox series

Message ID 20220707094402.28730-1-rishikeshdonadkar@gmail.com
Headers show
Series
  • Add colorimetry support to libcamera gstreamer element.
Related show

Message

Rishikesh Donadkar July 7, 2022, 9:43 a.m. UTC 
This series aims to add colorimetry support to the libcamera gstreamer
element.

If colorimetry is specified by the user in the gstreamer pipeline, try to
apply the libcamera colorspace corresponding to the GStreamer colorimetry
to the camera if the colorspace passes the validation then push the
colorimetry corresponding to the valid colorspace in the caps.
If the colorimetry pushed into the caps is same as requested negotiation
will succeed, else negotiation will fail.

If no colorimetry is specified by the user in the gstreamer pipeline,
push the GStreamer colorimetry corresponding to the current colorspace
applied to the camera into the caps and the negotiation will be take
care of by the gstreamer.


Rishikesh Donadkar (4):
  gstreamer: convert from libcamera colorspace toGStreamer colorimetry.
  gstreamer: Update the obtained colorimetry in caps.
  gstreamer:Convert between requested colorimetry and libcamera
    ColorSpace
  gstreamer: Configure the colorSpace in the Stream configuration.

 src/gstreamer/gstlibcamera-utils.cpp | 69 ++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)

Comments

Nicolas Dufresne July 7, 2022, 1:55 p.m. UTC | #1 
Le jeudi 07 juillet 2022 à 15:13 +0530, Rishikesh Donadkar via libcamera-devel a
écrit :
> This series aims to add colorimetry support to the libcamera gstreamer
> element.
> 
> If colorimetry is specified by the user in the gstreamer pipeline, try to
> apply the libcamera colorspace corresponding to the GStreamer colorimetry
> to the camera if the colorspace passes the validation then push the
> colorimetry corresponding to the valid colorspace in the caps.
> If the colorimetry pushed into the caps is same as requested negotiation
> will succeed, else negotiation will fail.
> 
> If no colorimetry is specified by the user in the gstreamer pipeline,
> push the GStreamer colorimetry corresponding to the current colorspace
> applied to the camera into the caps and the negotiation will be take
> care of by the gstreamer.

Nice to have, a little changelog would help your reviewer.

> 
> 
> Rishikesh Donadkar (4):
>   gstreamer: convert from libcamera colorspace toGStreamer colorimetry.
>   gstreamer: Update the obtained colorimetry in caps.
>   gstreamer:Convert between requested colorimetry and libcamera
>     ColorSpace
>   gstreamer: Configure the colorSpace in the Stream configuration.
> 
>  src/gstreamer/gstlibcamera-utils.cpp | 69 ++++++++++++++++++++++++++++
>  1 file changed, 69 insertions(+)
>