[libcamera-devel,v4,0/4] Add SensorTemperature control
mbox series

Message ID 20220629085722.11786-1-naush@raspberrypi.com
Headers show
Series
  • Add SensorTemperature control
Related show

Message

Naushir Patuck June 29, 2022, 8:57 a.m. UTC 
Hi,

The only change in this version is using the suggested std::optional::value_or()
function instead of the ternary operator in lux.cpp.

Thanks,
Naush

Naushir Patuck (4):
  libcamera: controls: Add SensorTemperature control
  ipa: raspberrypi: Add sensor temperature to DeviceStatus
  ipa: raspberrypi: imx477: Get sensor temperature from embedded data
  ipa: raspberrypi: Use std::optional in DeviceStatus

 src/ipa/raspberrypi/cam_helper.cpp              |  8 +++++---
 src/ipa/raspberrypi/cam_helper_imx477.cpp       |  5 ++++-
 .../raspberrypi/controller/device_status.cpp    | 17 +++++++++++++----
 src/ipa/raspberrypi/controller/device_status.h  | 12 +++++++-----
 src/ipa/raspberrypi/controller/rpi/lux.cpp      |  4 +---
 src/ipa/raspberrypi/raspberrypi.cpp             |  2 ++
 src/libcamera/control_ids.yaml                  | 10 ++++++++++
 7 files changed, 42 insertions(+), 16 deletions(-)

Comments

Kieran Bingham June 29, 2022, 11:06 a.m. UTC | #1 
Quoting Naushir Patuck via libcamera-devel (2022-06-29 09:57:18)
> Hi,
> 
> The only change in this version is using the suggested std::optional::value_or()
> function instead of the ternary operator in lux.cpp.

And you've collected tags too, so all that makes it easier for me to
merge. I'll get to this next. Thanks.

--
Kieran


> 
> Thanks,
> Naush
> 
> Naushir Patuck (4):
>   libcamera: controls: Add SensorTemperature control
>   ipa: raspberrypi: Add sensor temperature to DeviceStatus
>   ipa: raspberrypi: imx477: Get sensor temperature from embedded data
>   ipa: raspberrypi: Use std::optional in DeviceStatus
> 
>  src/ipa/raspberrypi/cam_helper.cpp              |  8 +++++---
>  src/ipa/raspberrypi/cam_helper_imx477.cpp       |  5 ++++-
>  .../raspberrypi/controller/device_status.cpp    | 17 +++++++++++++----
>  src/ipa/raspberrypi/controller/device_status.h  | 12 +++++++-----
>  src/ipa/raspberrypi/controller/rpi/lux.cpp      |  4 +---
>  src/ipa/raspberrypi/raspberrypi.cpp             |  2 ++
>  src/libcamera/control_ids.yaml                  | 10 ++++++++++
>  7 files changed, 42 insertions(+), 16 deletions(-)
> 
> -- 
> 2.25.1
>
Naushir Patuck June 29, 2022, 11:56 a.m. UTC | #2 
On Wed, 29 Jun 2022 at 12:06, Kieran Bingham <
kieran.bingham@ideasonboard.com> wrote:

> Quoting Naushir Patuck via libcamera-devel (2022-06-29 09:57:18)
> > Hi,
> >
> > The only change in this version is using the suggested
> std::optional::value_or()
> > function instead of the ternary operator in lux.cpp.
>
> And you've collected tags too, so all that makes it easier for me to
> merge. I'll get to this next. Thanks.
>

Thanks Kieran!

PS the "Correct ControlInfoMap from the IPA" series needs only one more R-B
tag for 3/3 if you are feeling bored ;-)



>
> --
> Kieran
>
>
> >
> > Thanks,
> > Naush
> >
> > Naushir Patuck (4):
> >   libcamera: controls: Add SensorTemperature control
> >   ipa: raspberrypi: Add sensor temperature to DeviceStatus
> >   ipa: raspberrypi: imx477: Get sensor temperature from embedded data
> >   ipa: raspberrypi: Use std::optional in DeviceStatus
> >
> >  src/ipa/raspberrypi/cam_helper.cpp              |  8 +++++---
> >  src/ipa/raspberrypi/cam_helper_imx477.cpp       |  5 ++++-
> >  .../raspberrypi/controller/device_status.cpp    | 17 +++++++++++++----
> >  src/ipa/raspberrypi/controller/device_status.h  | 12 +++++++-----
> >  src/ipa/raspberrypi/controller/rpi/lux.cpp      |  4 +---
> >  src/ipa/raspberrypi/raspberrypi.cpp             |  2 ++
> >  src/libcamera/control_ids.yaml                  | 10 ++++++++++
> >  7 files changed, 42 insertions(+), 16 deletions(-)
> >
> > --
> > 2.25.1
> >
>
Kieran Bingham June 29, 2022, 1:08 p.m. UTC | #3 
Quoting Naushir Patuck (2022-06-29 12:56:15)
> On Wed, 29 Jun 2022 at 12:06, Kieran Bingham <
> kieran.bingham@ideasonboard.com> wrote:
> 
> > Quoting Naushir Patuck via libcamera-devel (2022-06-29 09:57:18)
> > > Hi,
> > >
> > > The only change in this version is using the suggested
> > std::optional::value_or()
> > > function instead of the ternary operator in lux.cpp.
> >
> > And you've collected tags too, so all that makes it easier for me to
> > merge. I'll get to this next. Thanks.
> >
> 
> Thanks Kieran!
> 
> PS the "Correct ControlInfoMap from the IPA" series needs only one more R-B
> tag for 3/3 if you are feeling bored ;-)

Done, that's both of these merged now.
--
Kieran


> 
> 
> 
> >
> > --
> > Kieran
> >
> >
> > >
> > > Thanks,
> > > Naush
> > >
> > > Naushir Patuck (4):
> > >   libcamera: controls: Add SensorTemperature control
> > >   ipa: raspberrypi: Add sensor temperature to DeviceStatus
> > >   ipa: raspberrypi: imx477: Get sensor temperature from embedded data
> > >   ipa: raspberrypi: Use std::optional in DeviceStatus
> > >
> > >  src/ipa/raspberrypi/cam_helper.cpp              |  8 +++++---
> > >  src/ipa/raspberrypi/cam_helper_imx477.cpp       |  5 ++++-
> > >  .../raspberrypi/controller/device_status.cpp    | 17 +++++++++++++----
> > >  src/ipa/raspberrypi/controller/device_status.h  | 12 +++++++-----
> > >  src/ipa/raspberrypi/controller/rpi/lux.cpp      |  4 +---
> > >  src/ipa/raspberrypi/raspberrypi.cpp             |  2 ++
> > >  src/libcamera/control_ids.yaml                  | 10 ++++++++++
> > >  7 files changed, 42 insertions(+), 16 deletions(-)
> > >
> > > --
> > > 2.25.1
> > >
> >