| Message ID | 20220622102047.22492-1-naush@raspberrypi.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi all, Any other takers for a review on this series? The patches need one more R-B tag. Regards, Naush On Wed, 22 Jun 2022 at 11:20, Naushir Patuck <naush@raspberrypi.com> wrote: > Hi, > > In v3 of this series, I've made the following changes: > - Added the Bug tag in patch 1/3. > - Fix typo in commit message in patch 2/3. > - Patch 2/3 also keeps some default values for ExposureTime, AnalogeGain > and > FrameDuration controls during the ipa::init() as requested. > - Use the frame duration to calculate the correct exposure time limit in > patch 2/3. > > I've left the code using the ControlInfoMap::Map mechanism to add values > to a > ControlInfoMap container. At a later date, I may attempt to change this by > adding a ControlInfoMap::add() member function. But if this API is to be > replaced > by something else, it may not be worth it...? > > Regards, > Naush > > Naushir Patuck (3): > pipeline: ipa: raspberrypi: Move ControlInfoMap to the IPA > pipeline: ipa: raspberrypi: Correctly report available control limits > pipeline: raspberrypi: Advertise ScalerCrop from the pipeline handler > > include/libcamera/ipa/raspberrypi.h | 55 ---------------- > include/libcamera/ipa/raspberrypi.mojom | 8 ++- > src/ipa/raspberrypi/raspberrypi.cpp | 66 +++++++++++++++++-- > .../pipeline/raspberrypi/raspberrypi.cpp | 41 +++++++----- > .../pipeline/raspberrypi/rpi_stream.h | 1 - > 5 files changed, 92 insertions(+), 79 deletions(-) > delete mode 100644 include/libcamera/ipa/raspberrypi.h > > -- > 2.25.1 > >
Quoting Naushir Patuck via libcamera-devel (2022-06-27 12:32:24) > Hi all, > > Any other takers for a review on this series? The patches need one more > R-B tag. David, have you tested these patches already as well? -- Kieran > > Regards, > Naush > > On Wed, 22 Jun 2022 at 11:20, Naushir Patuck <naush@raspberrypi.com> wrote: > > > Hi, > > > > In v3 of this series, I've made the following changes: > > - Added the Bug tag in patch 1/3. > > - Fix typo in commit message in patch 2/3. > > - Patch 2/3 also keeps some default values for ExposureTime, AnalogeGain > > and > > FrameDuration controls during the ipa::init() as requested. > > - Use the frame duration to calculate the correct exposure time limit in > > patch 2/3. > > > > I've left the code using the ControlInfoMap::Map mechanism to add values > > to a > > ControlInfoMap container. At a later date, I may attempt to change this by > > adding a ControlInfoMap::add() member function. But if this API is to be > > replaced > > by something else, it may not be worth it...? > > > > Regards, > > Naush > > > > Naushir Patuck (3): > > pipeline: ipa: raspberrypi: Move ControlInfoMap to the IPA > > pipeline: ipa: raspberrypi: Correctly report available control limits > > pipeline: raspberrypi: Advertise ScalerCrop from the pipeline handler > > > > include/libcamera/ipa/raspberrypi.h | 55 ---------------- > > include/libcamera/ipa/raspberrypi.mojom | 8 ++- > > src/ipa/raspberrypi/raspberrypi.cpp | 66 +++++++++++++++++-- > > .../pipeline/raspberrypi/raspberrypi.cpp | 41 +++++++----- > > .../pipeline/raspberrypi/rpi_stream.h | 1 - > > 5 files changed, 92 insertions(+), 79 deletions(-) > > delete mode 100644 include/libcamera/ipa/raspberrypi.h > > > > -- > > 2.25.1 > > > >