[libcamera-devel,v2,0/3] Documentation: Update code examples in Application Writer's Guide
mbox series

Message ID 20220617143549.35442-1-dse@thaumatec.com
Headers show
Series
  • Documentation: Update code examples in Application Writer's Guide
Related show

Message

Daniel Semkowicz June 17, 2022, 2:35 p.m. UTC 
Hello,

Here is the corrected version of changes in the documentation.

- Rebase changes on top of already merged unique_ptr fix
- Add changes according to the discussion with Laurent and Jacopo

Best regards
Daniel Semkowicz

Daniel Semkowicz (3):
  Documentation: Add the missing const to the example code
  Documentation: Update code examples to use the Request::reuse() method
  Documentation: Update the "Start an event loop" section

 .../guides/application-developer.rst          | 62 +++++++------------
 1 file changed, 21 insertions(+), 41 deletions(-)

Comments

Jacopo Mondi June 17, 2022, 3:05 p.m. UTC | #1 
Hi Daniel,

On Fri, Jun 17, 2022 at 04:35:46PM +0200, Daniel Semkowicz via libcamera-devel wrote:
> Hello,
>
> Here is the corrected version of changes in the documentation.
>
> - Rebase changes on top of already merged unique_ptr fix
> - Add changes according to the discussion with Laurent and Jacopo
>
> Best regards
> Daniel Semkowicz
>
Thanks, with Laurent's comment fixed when applying

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>


> Daniel Semkowicz (3):
>   Documentation: Add the missing const to the example code
>   Documentation: Update code examples to use the Request::reuse() method
>   Documentation: Update the "Start an event loop" section
>
>  .../guides/application-developer.rst          | 62 +++++++------------
>  1 file changed, 21 insertions(+), 41 deletions(-)
>
> --
> 2.34.1
>