| Message ID | 20220310120540.15296-1-david.plowman@raspberrypi.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi David ! On 10/03/2022 13:05, David Plowman via libcamera-devel wrote: > Hi everyone > > Here is a first non-RFC version of the proposed AF (autofocus) > controls. > > There's been quite a bit of discussion already at the RFC stage, most > notably the introduction of a manual mode, aimed at making integration > with Android easier, and an explicit control for pausing CAF > (continuous autofocus). I also removed the AfMethod control as it > seems redundant, though I still wonder slightly if some platforms > might have alterative ways of handling multi-spot AF. > > It's quite possible that I've forgotten to incorporate some > suggestions that were made previously in which case I apologise - > please point them out to me again! > > Further suggestions and discussion are of course most welcome! Do you know when you may be able to send a v2 ? I really would like to see it integrated quickly now, and I am sure we are not very far from it :-). Thanks ! JM > > Thanks and best best regards > > David > > David Plowman (1): > libcamera: controls: Controls for driving AF (autofocus) algorithms > > src/libcamera/control_ids.yaml | 271 +++++++++++++++++++++++++-------- > 1 file changed, 211 insertions(+), 60 deletions(-) >
Hi Jean-Michel Thanks for the prod! Yes, I'll get on with this. One of the main things was to produce a state transition diagram, so I'll do that too. Previously the AfState merely reported reset/scanning/failed/focused without saying what the AfMode was, but I'm thinking I might change this so that the mode is included as well. The Android version is like this, and whilst it seems like it might be unnecessary, at least you're sure if the algorithm has seen any new AfMode that you might have set (given how asynchronous things can be). But I'll put all this in version 2. Thanks! David On Wed, 30 Mar 2022 at 10:10, Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com> wrote: > > Hi David ! > > On 10/03/2022 13:05, David Plowman via libcamera-devel wrote: > > Hi everyone > > > > Here is a first non-RFC version of the proposed AF (autofocus) > > controls. > > > > There's been quite a bit of discussion already at the RFC stage, most > > notably the introduction of a manual mode, aimed at making integration > > with Android easier, and an explicit control for pausing CAF > > (continuous autofocus). I also removed the AfMethod control as it > > seems redundant, though I still wonder slightly if some platforms > > might have alterative ways of handling multi-spot AF. > > > > It's quite possible that I've forgotten to incorporate some > > suggestions that were made previously in which case I apologise - > > please point them out to me again! > > > > Further suggestions and discussion are of course most welcome! > > Do you know when you may be able to send a v2 ? > I really would like to see it integrated quickly now, and I am sure we > are not very far from it :-). > > Thanks ! > JM > > > > > Thanks and best best regards > > > > David > > > > David Plowman (1): > > libcamera: controls: Controls for driving AF (autofocus) algorithms > > > > src/libcamera/control_ids.yaml | 271 +++++++++++++++++++++++++-------- > > 1 file changed, 211 insertions(+), 60 deletions(-) > >