[libcamera-devel,0/2] ipa: rkisp1: Replace event-based ops with dedicated functions
mbox series

Message ID 20220308091520.34607-1-umang.jain@ideasonboard.com
Headers show
Series
  • ipa: rkisp1: Replace event-based ops with dedicated functions
Related show

Message

Nicolas Dufresne via libcamera-devel March 8, 2022, 9:15 a.m. UTC 
1/1 is a cleanup patch.
2/2 is the patch which removes the Actions/operation mechanics from the
interface.

Patches are smoke-tested by Paul on rkisp1 hardware.

Umang Jain (2):
  ipa: rkisp1: Drop private exposure and gain limits
  ipa: rkisp1: Replace event-based ops with dedicated functions

 include/libcamera/ipa/rkisp1.mojom       |  31 ++-----
 src/ipa/rkisp1/rkisp1.cpp                | 106 +++++++----------------
 src/libcamera/pipeline/rkisp1/rkisp1.cpp |  71 ++++++---------
 3 files changed, 66 insertions(+), 142 deletions(-)

Comments

Nicolas Dufresne via libcamera-devel March 15, 2022, 9:49 a.m. UTC | #1 
Hi Umang,

On Tue, Mar 08, 2022 at 02:45:18PM +0530, Umang Jain via libcamera-devel wrote:
> 1/1 is a cleanup patch.
> 2/2 is the patch which removes the Actions/operation mechanics from the
> interface.
> 
> Patches are smoke-tested by Paul on rkisp1 hardware.

For both,

Tested-by: Paul Elder <paul.elder@ideasonboard.com>

> 
> Umang Jain (2):
>   ipa: rkisp1: Drop private exposure and gain limits
>   ipa: rkisp1: Replace event-based ops with dedicated functions
> 
>  include/libcamera/ipa/rkisp1.mojom       |  31 ++-----
>  src/ipa/rkisp1/rkisp1.cpp                | 106 +++++++----------------
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp |  71 ++++++---------
>  3 files changed, 66 insertions(+), 142 deletions(-)
> 
> -- 
> 2.31.1
>