[libcamera-devel,v4,0/4] ipa: ipu3: Misc clean up
mbox series

Message ID 20220224151113.109858-1-jeanmichel.hautbois@ideasonboard.com
Headers show
Series
  • ipa: ipu3: Misc clean up
Related show

Message

Jean-Michel Hautbois Feb. 24, 2022, 3:11 p.m. UTC 
Hello,

While working on AGC porting from IPU3 to RkISP1, a few minor changes
were proposed to clean the variables and function usage.

Report those changes in IPU3.

In v2:
  - Correct the filterExposure() calculation to use the same as RkISP1
  - Rewrite some comments
  - Remove the caching of analogue gain and exposure

In v3:
  - Remove all local references to lineDuration_ and use the context
    everywhere in IPAIPU3

In v4:
  - Remove lineDuration calculation in IPU3Agc::configure
  - Clean only frameContext at configure()
  - Add clamping of gain values in IPU3Awb

Jean-Michel Hautbois (4):
  ipa: ipu3: Return filtered value
  ipa: ipu3: Shorten exposure and gain lines
  ipa: ipu3: agc: Introduce lineDuration in IPASessionConfiguration
  ipa: ipu3: awb: Clamp gain values

 src/ipa/ipu3/algorithms/agc.cpp | 100 +++++++++++++++++---------------
 src/ipa/ipu3/algorithms/agc.h   |   6 +-
 src/ipa/ipu3/algorithms/awb.cpp |   8 +++
 src/ipa/ipu3/ipa_context.cpp    |   8 +++
 src/ipa/ipu3/ipa_context.h      |   4 ++
 src/ipa/ipu3/ipu3.cpp           |  35 ++++++-----
 6 files changed, 96 insertions(+), 65 deletions(-)