[libcamera-devel,v3,0/8] The Great AE Changes
mbox series

Message ID 20211221043610.2512334-1-paul.elder@ideasonboard.com
Headers show
Series
  • The Great AE Changes
Related show

Message

Paul Elder Dec. 21, 2021, 4:36 a.m. UTC 
This patch series aims to solve all our AE problems.

The most important patches are 1/8, 6/8, and 8/8.

1/8 defines the new AE controls, and replaces the old ones. This will
not compile without 2/8 to 5/8. Should this be squashed, to prevent
bisection breakage, or left separate, for clean history?

6/8 plumbs the AE controls through the HAL layer. It is fairly large and
complex. This one needs a bit more discussion, and as a result has not
been changed much since v2.

8/8 plumbs the sensitivity-related controls, which are also related to
the AE controls, which is why it is included in this series. It also did
not have any reviews, so it's being grouped with this series.

7/8 was moved from "android: Miscellaneous fixes", as of v3, to avoid
breakage in that series. It is already reviewed (and actually one
version ahead) and is included here to avoid getting lost.

Paul Elder (8):
  controls: Reorganize the AE-related controls
  libcamera: pipeline: uvcvideo: Support the new AE controls
  libcamera: pipeline: raspberrypi: Support the new AE controls
  test: ipa_data_serializer: Remove controls::AeEnable
  libcamera: pipeline: rkisp1: Support the new AE controls
  android: Plumb all AE-related controls
  android: Check exposure time range for manual sensor capability
  android: Plumb all sensitivity-related controls

 include/libcamera/ipa/raspberrypi.h           |   3 +-
 src/android/camera_capabilities.cpp           | 169 +++++++++++--
 src/android/camera_capabilities.h             |   3 +-
 src/android/camera_device.cpp                 | 157 +++++++++++-
 src/android/camera_device.h                   |  14 +
 src/android/camera_hal_config.cpp             |  10 +-
 src/android/camera_hal_config.h               |   1 +
 src/android/camera_request.h                  |   9 +
 .../raspberrypi/controller/agc_algorithm.hpp  |   4 +
 src/ipa/raspberrypi/controller/rpi/agc.cpp    |  22 +-
 src/ipa/raspberrypi/controller/rpi/agc.hpp    |   5 +
 src/ipa/raspberrypi/raspberrypi.cpp           |  42 ++-
 src/ipa/rkisp1/rkisp1.cpp                     |   9 +-
 src/libcamera/control_ids.yaml                | 239 +++++++++++++-----
 src/libcamera/pipeline/rkisp1/rkisp1.cpp      |   4 +-
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  43 +++-
 .../ipa_data_serializer_test.cpp              |   1 -
 17 files changed, 624 insertions(+), 111 deletions(-)