[libcamera-devel,v5,0/7] Colour spaces
mbox series

Message ID 20211104135805.5269-1-david.plowman@raspberrypi.com
Headers show
Series
  • Colour spaces
Related show

Message

David Plowman Nov. 4, 2021, 1:57 p.m. UTC 
Hi again

Here's v5, which is different to v4 only in that I've rebased the
Raspberry Pi PH changes (the final commit) on top of its recent
media-controller-ification. It's not a big change, but things are very
slightly different there now.

This has shown up one little niggle, which is that the V4L2 subdevice
now complains about retrieving an undefined colour space - from the
metadata pad! Currently I've left the warning in but added the pad
number in the message. The metadata pad is easy to spot in practice
because it always has a non-zero pad number. But is there a proper way
to know this?

Thanks

David

David Plowman (7):
  libcamera: Add ColorSpace class
  libcamera: Add ColorSpace fields to StreamConfiguration
  libcamera: Convert between ColorSpace class and V4L2 formats
  libcamera: Support passing ColorSpaces to V4L2 video devices
  libcamera: Support passing ColorSpaces to V4L2 subdevices
  libcamera: Add validateColorSpaces to CameraConfiguration class
  libcamera: pipeline: raspberrypi: Support color spaces

 include/libcamera/camera.h                    |   2 +
 include/libcamera/color_space.h               |  88 ++++++
 include/libcamera/internal/v4l2_device.h      |   7 +
 include/libcamera/internal/v4l2_subdevice.h   |   2 +
 include/libcamera/internal/v4l2_videodevice.h |   2 +
 include/libcamera/meson.build                 |   1 +
 include/libcamera/stream.h                    |   4 +
 src/libcamera/camera.cpp                      |  51 ++++
 src/libcamera/camera_sensor.cpp               |   1 +
 src/libcamera/color_space.cpp                 | 257 ++++++++++++++++++
 src/libcamera/meson.build                     |   1 +
 .../pipeline/raspberrypi/raspberrypi.cpp      |  42 +++
 src/libcamera/stream.cpp                      |  25 ++
 src/libcamera/v4l2_device.cpp                 | 171 ++++++++++++
 src/libcamera/v4l2_subdevice.cpp              |  42 ++-
 src/libcamera/v4l2_videodevice.cpp            |  67 ++++-
 16 files changed, 758 insertions(+), 5 deletions(-)
 create mode 100644 include/libcamera/color_space.h
 create mode 100644 src/libcamera/color_space.cpp