Return-Path: <jacopo@jmondi.org> Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BCF862F56 for <libcamera-devel@lists.libcamera.org>; Wed, 12 Jun 2019 15:37:10 +0200 (CEST) X-Originating-IP: 2.224.242.101 Received: from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101]) (Authenticated sender: jacopo@jmondi.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id C894060012; Wed, 12 Jun 2019 13:37:09 +0000 (UTC) From: Jacopo Mondi <jacopo@jmondi.org> To: libcamera-devel@lists.libcamera.org Date: Wed, 12 Jun 2019 15:38:15 +0200 Message-Id: <20190612133817.32731-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [libcamera-devel] [PATCH v2 0/2] libcamera: Introduce V4L2Device base class X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: <libcamera-devel.lists.libcamera.org> List-Unsubscribe: <https://lists.libcamera.org/options/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe> List-Archive: <https://lists.libcamera.org/pipermail/libcamera-devel/> List-Post: <mailto:libcamera-devel@lists.libcamera.org> List-Help: <mailto:libcamera-devel-request@lists.libcamera.org?subject=help> List-Subscribe: <https://lists.libcamera.org/listinfo/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe> X-List-Received-Date: Wed, 12 Jun 2019 13:37:10 -0000
Thanks to Kieran the patch is now split in 2: rename then V4L2Device introduction. To address Laurent's request, only V4L2Device is now renamed in V4L2VideoDevice and V4L2Subdevice stays the same. A few minor changes in the newly introduced V4L2Device base class to address a few review comments. Thanks Kieran for helping in splitting the patch, hopefully it is more easily reviewable in this state. Thanks j Jacopo Mondi (2): libcamera: Rename V4L2Device to V4L2VideoDevice libcamera: Introduce V4L2Device base class include/libcamera/buffer.h | 2 +- src/libcamera/include/v4l2_device.h | 166 +-- src/libcamera/include/v4l2_subdevice.h | 6 +- src/libcamera/include/v4l2_videodevice.h | 183 ++++ src/libcamera/meson.build | 2 + src/libcamera/pipeline/ipu3/ipu3.cpp | 24 +- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 6 +- src/libcamera/pipeline/uvcvideo.cpp | 6 +- src/libcamera/pipeline/vimc.cpp | 6 +- src/libcamera/v4l2_device.cpp | 980 +---------------- src/libcamera/v4l2_subdevice.cpp | 68 +- src/libcamera/v4l2_videodevice.cpp | 991 ++++++++++++++++++ test/meson.build | 2 +- .../buffer_sharing.cpp | 18 +- .../capture_async.cpp | 6 +- .../double_open.cpp | 8 +- .../formats.cpp | 8 +- .../meson.build | 8 +- .../request_buffers.cpp | 6 +- .../stream_on_off.cpp | 6 +- .../v4l2_videodevice_test.cpp} | 8 +- .../v4l2_videodevice_test.h} | 8 +- 22 files changed, 1321 insertions(+), 1197 deletions(-) create mode 100644 src/libcamera/include/v4l2_videodevice.h create mode 100644 src/libcamera/v4l2_videodevice.cpp rename test/{v4l2_device => v4l2_videodevice}/buffer_sharing.cpp (90%) rename test/{v4l2_device => v4l2_videodevice}/capture_async.cpp (91%) rename test/{v4l2_device => v4l2_videodevice}/double_open.cpp (75%) rename test/{v4l2_device => v4l2_videodevice}/formats.cpp (85%) rename test/{v4l2_device => v4l2_videodevice}/meson.build (74%) rename test/{v4l2_device => v4l2_videodevice}/request_buffers.cpp (77%) rename test/{v4l2_device => v4l2_videodevice}/stream_on_off.cpp (78%) rename test/{v4l2_device/v4l2_device_test.cpp => v4l2_videodevice/v4l2_videodevice_test.cpp} (90%) rename test/{v4l2_device/v4l2_device_test.h => v4l2_videodevice/v4l2_videodevice_test.h} (81%) -- 2.21.0