[libcamera-devel,0/3] Fix dark caputred image with close sourced IPU3 IPA
mbox series

Message ID mailman.441.1633340910.837.libcamera-devel@lists.libcamera.org
Headers show
Series
  • Fix dark caputred image with close sourced IPU3 IPA
Related show

Message

Nicolas Dufresne via libcamera-devel Oct. 4, 2021, 9:48 a.m. UTC 
From: hanlinchen <hanlinchen@google.com>

Hi everyone,

We have a issue that the captured image is extremely dark with the close
sourced IPU3 IPA on soraka. The problem is due to that the codes from Chrome
OS not handling memories correctly. In result, the statistic as input to AIQ
is cleared early and the calculated exposure is wrong. A similiar issue
prevent it to apply lens shading correction too, which causes crash due to
invalid contents of SA results.

The patch series fixes the issue by:
1. Refactor the memory recycles and fix copying overflown.
2. Apply shading lens correction to further brighten the image.

hanlinchen (3):
  ipu3: Remove the usage of SharedItemPool
  ipu3: Change Macro migrated from Chrome OS to its std version
    accordingly
  ipu3: Apply shading adapter as part of AIQ::run2a()

 aiq/aiq.cpp                  |  20 ++++-
 aiq/aiq.h                    |   4 +-
 aiq/aiq_input_parameters.cpp |  50 +++++-------
 aiq/aiq_results.cpp          |  91 +++++++++-------------
 ipu3.cpp                     |   2 +-
 stats/ipa_ipu3_stats.cpp     | 145 ++++++-----------------------------
 stats/ipa_ipu3_stats.h       |  41 ++++++----
 stats/meson.build            |   1 -
 stats/shared_item_pool.cpp   | 129 -------------------------------
 stats/shared_item_pool.h     | 114 ---------------------------
 10 files changed, 127 insertions(+), 470 deletions(-)
 delete mode 100644 stats/shared_item_pool.cpp
 delete mode 100644 stats/shared_item_pool.h