[libcamera-devel,v3,0/3] android: Request one stream for identica stream requests
mbox series

Message ID 20210831093439.853586-1-hiroh@chromium.org
Headers show
Series
  • android: Request one stream for identica stream requests
Related show

Message

Hirokazu Honda Aug. 31, 2021, 9:34 a.m. UTC
Android HAL client may request multiple streams, whose formats and
resolutions are same. This patch series confgiures one stream for
the identical stream requests so that the requests can be accepted
as much as possible.

With this patch series, 10 tests out of 18 CTS tests requesting
multiple streams newly pass.

[1/18] android.hardware.camera2.cts.RobustnessTest#testMandatoryOutputCombinations pass
[2/18] android.hardware.cts.CameraTest#testFocusDistances pass
[3/18] android.hardware.cts.CameraTest#testImmediateZoom fail
[4/18] android.hardware.cts.CameraTest#testPreviewCallback pass
[5/18] android.hardware.cts.CameraTest#testPreviewCallbackWithBuffer fail
[6/18] android.hardware.cts.CameraTest#testPreviewCallbackWithPicture pass
[7/18] android.hardware.cts.CameraTest#testPreviewFormats pass
[8/18] android.hardware.cts.CameraTest#testPreviewFpsRange pass
[9/18] android.hardware.cts.CameraTest#testPreviewPictureSizesCombination fail
[10/18] android.hardware.cts.CameraTest#testSetOneShotPreviewCallback pass
[11/18] android.hardware.cts.CameraTest#testSetPreviewDisplay pass
[12/18] android.hardware.cts.CameraTest#testVideoSnapshot fail
[13/18] android.hardware.cts.CameraGLTest#testSetPreviewTextureBothCallbacks pass
[14/18] android.hardware.cts.CameraGLTest#testSetPreviewTexturePreviewCallback pass
[15/18] android.hardware.multiprocess.camera.cts.CameraEvictionTest#testMediaRecorderCameraActivityEviction fail
[16/18] android.hardware.camera2.cts.StillCaptureTest#testStillPreviewCombination fail
[17/18]android.hardware.camera2.cts.SurfaceViewPreviewTest#testDeferredSurfaces fail
[18/18] android.hardware.camera2.cts.ImageReaderTest#testAllOutputYUVResolutions fail

I found sometimes more tests failed (only 5 test passes for example).
I am looking into the issue. But in my humble opinion, this patch
series doesn't cause make things worse and therefore okay to be merged.

change in v3:
- Address Jacopo's comments
change in v2:
- Address Jacopo's comments

Hirokazu Honda (3):
  android: camera_stream: Create post processor in configure()
  android: camera_stream: Support PostProcessorYuv in CameraStream
  android: camera_device: Configure one stream for identical stream
    requests

 src/android/camera_device.cpp | 28 ++++++++++++++++----
 src/android/camera_device.h   |  1 +
 src/android/camera_stream.cpp | 50 +++++++++++++++++++++--------------
 3 files changed, 54 insertions(+), 25 deletions(-)

--
2.33.0.259.gc128427fd7-goog