[libcamera-devel,SimpleCam,0/4] Improve CameraManager usage and Doc
mbox series

Message ID 20210824142450.3157833-1-kieran.bingham@ideasonboard.com
Headers show
Series
  • Improve CameraManager usage and Doc
Related show

Message

Kieran Bingham Aug. 24, 2021, 2:24 p.m. UTC 
The CameraManager was not being released before the end of the
application. While this does not cause any direct issues, it counts as a
memory leak.

Demonstrate a cleaner way to manage the CameraManager using a unique_ptr
to convey that the application is responsible for it's lifetime.

Along the way, improve the documentation throughout.

Kieran Bingham (4):
  simple-cam: Use a unique_ptr for the CameraManager
  simple-cam: Improve documentation of validate/configure
  simple-cam: Fix the Buffer Allocation guidance
  simple-cam: Correct the capitalisation of 'libcamera'

 simple-cam.cpp | 37 ++++++++++++++++++++++++++-----------
 1 file changed, 26 insertions(+), 11 deletions(-)

Comments

Paul Elder Aug. 25, 2021, 2:17 a.m. UTC | #1 
Hi Kieran,

On Tue, Aug 24, 2021 at 03:24:46PM +0100, Kieran Bingham wrote:
> The CameraManager was not being released before the end of the
> application. While this does not cause any direct issues, it counts as a
> memory leak.
> 
> Demonstrate a cleaner way to manage the CameraManager using a unique_ptr
> to convey that the application is responsible for it's lifetime.
> 
> Along the way, improve the documentation throughout.

Looks good.

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> 
> Kieran Bingham (4):
>   simple-cam: Use a unique_ptr for the CameraManager
>   simple-cam: Improve documentation of validate/configure
>   simple-cam: Fix the Buffer Allocation guidance
>   simple-cam: Correct the capitalisation of 'libcamera'
> 
>  simple-cam.cpp | 37 ++++++++++++++++++++++++++-----------
>  1 file changed, 26 insertions(+), 11 deletions(-)
> 
> -- 
> 2.30.2
>