[libcamera-devel,0/4] ipu3: Change sensor size selection policy
mbox series

Message ID 20210803133205.6599-1-umang.jain@ideasonboard.com
Headers show
Series
  • ipu3: Change sensor size selection policy
Related show

Message

Umang Jain Aug. 3, 2021, 1:32 p.m. UTC 
The series is geared towards addressing sensor selection constraints
on soraka and nautilus. 1/4 and 2/4 prepares the base to highlight
the change in selection policy. 3/4 and 4/4 is the actual change.

The constraints are documented in the commit messages of 3/4 and 4/4.

Jacopo Mondi (1):
  ipu3: cio2:  Change sensor size selection policy

Umang Jain (3):
  libcamera: camera_sensor: Transform CameraSensor::sizes()
  ipu3: cio2: Replicate CameraSensor::getFormats() to a member function
  ipu3: cio2: Tweak sensor size selection policy

 include/libcamera/internal/camera_sensor.h |   2 +-
 src/libcamera/camera_sensor.cpp            |  36 +++++--
 src/libcamera/pipeline/ipu3/cio2.cpp       | 110 +++++++++++++++++++--
 src/libcamera/pipeline/ipu3/cio2.h         |   3 +
 test/camera-sensor.cpp                     |   2 +-
 5 files changed, 135 insertions(+), 18 deletions(-)

Comments

Jacopo Mondi Aug. 9, 2021, 4:59 p.m. UTC | #1 
Hi Umang,

On Tue, Aug 03, 2021 at 07:02:01PM +0530, Umang Jain wrote:
> The series is geared towards addressing sensor selection constraints
> on soraka and nautilus. 1/4 and 2/4 prepares the base to highlight
> the change in selection policy. 3/4 and 4/4 is the actual change.
>
> The constraints are documented in the commit messages of 3/4 and 4/4.
>
> Jacopo Mondi (1):
>   ipu3: cio2:  Change sensor size selection policy
>
> Umang Jain (3):
>   libcamera: camera_sensor: Transform CameraSensor::sizes()
>   ipu3: cio2: Replicate CameraSensor::getFormats() to a member function
>   ipu3: cio2: Tweak sensor size selection policy

I've tested this series with applied on top the patch that has been
circulating around to use the 'optimal' sensor size instead of always
defaulting to the max resolution in the IPU3 pipeline handler.

I've noticed no regressions in CTS due to size configuration issues,
so you can add

Tested-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
   j

>
>  include/libcamera/internal/camera_sensor.h |   2 +-
>  src/libcamera/camera_sensor.cpp            |  36 +++++--
>  src/libcamera/pipeline/ipu3/cio2.cpp       | 110 +++++++++++++++++++--
>  src/libcamera/pipeline/ipu3/cio2.h         |   3 +
>  test/camera-sensor.cpp                     |   2 +-
>  5 files changed, 135 insertions(+), 18 deletions(-)
>
> --
> 2.31.0
>