[libcamera-devel,0/3] libcamera: ipa_manager: Fix, cleanup, and allow forcing isolation
mbox series

Message ID 20210711231547.19664-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • libcamera: ipa_manager: Fix, cleanup, and allow forcing isolation
Related show

Message

Laurent Pinchart July 11, 2021, 11:15 p.m. UTC 
Hello,

This small patch series includes a fix and a cleanup for the IPAManager
class, as well as the ability to force IPA module isolation for test
purpose. There's not much else to be said, please see individual patches
for details.

Laurent Pinchart (3):
  libcamera: ipa_manager: Fix IPA module min/max version check
  libcamera: ipa_manager: Split common code out of createIPA()
  libcamera: ipa_manager: Allow forcing IPA module isolation

 Documentation/environment_variables.rst  |  5 +++++
 include/libcamera/internal/ipa_manager.h | 17 ++++++----------
 src/libcamera/ipa_manager.cpp            | 25 ++++++++++++++++++++++++
 3 files changed, 36 insertions(+), 11 deletions(-)

Comments

Umang Jain July 18, 2021, 1:30 p.m. UTC | #1 
Hi Laurent,

Thanks for the series.

On 7/12/21 4:45 AM, Laurent Pinchart wrote:
> Hello,
>
> This small patch series includes a fix and a cleanup for the IPAManager
> class, as well as the ability to force IPA module isolation for test
> purpose. There's not much else to be said, please see individual patches
> for details.
>
> Laurent Pinchart (3):
>    libcamera: ipa_manager: Fix IPA module min/max version check
>    libcamera: ipa_manager: Split common code out of createIPA()
>    libcamera: ipa_manager: Allow forcing IPA module isolation

For all 3 patches,

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

>
>   Documentation/environment_variables.rst  |  5 +++++
>   include/libcamera/internal/ipa_manager.h | 17 ++++++----------
>   src/libcamera/ipa_manager.cpp            | 25 ++++++++++++++++++++++++
>   3 files changed, 36 insertions(+), 11 deletions(-)
>