[libcamera-devel,0/2] utils: ipc: proxy: Always reset ControlSerializer during IPA configure
mbox series

Message ID 20210708082145.122160-1-umang.jain@ideasonboard.com
Headers show
Series
  • utils: ipc: proxy: Always reset ControlSerializer during IPA configure
Related show

Message

Umang Jain July 8, 2021, 8:21 a.m. UTC 
This is a small patch which seems to fix issue highlighted by:
https://bugs.libcamera.org/show_bug.cgi?id=58

1/2 is a DNI, which can help for logging in isolated IPA mode.

However, while testing this series with CTS, a new issue has been
identified related to open/lingering fds. For what I can see, it is
unrelated to this fix. So expect that some CTS tests will fail still
in isolated mode, but hopefully Bug#58 behaviour isn't reproduced,
if you carry this change.

The new issue, if you get hit, might be along these lines:
(In isolated IPA log)
[0:20:15.723915030] [10202] FATAL FileDescriptor file_descriptor.cpp:235 Failed to dup() fd: Too many open files
Backtrace:

(cros_camera_service)
[0:20:17.724419941] [10201] ERROR IPCPipe ipc_pipe_unixsocket.cpp:134 Call timeout!
[0:20:17.724586917] [10201] ERROR IPCPipe ipc_pipe_unixsocket.cpp:66 Failed to call sync
[0:20:17.724612298] [10201] ERROR IPAProxy ipu3_ipa_proxy.cpp:338 Failed to call mapBuffers
...
[0:20:27.200651034] [10201] ERROR IPCPipe ipc_pipe_unixsocket.cpp:66 Failed to call sync
[0:20:27.200667808] [10201] ERROR IPAProxy ipu3_ipa_proxy.cpp:288 Failed to call configure
[0:20:27.200684272] [10201] ERROR IPU3 ipu3.cpp:648 Failed to configure IPA: Connection timed out
... More CTS test failures down the line.

Umang Jain (2):
  DNI: Enforce IPA isolation and set log file path
  utils: ipc: proxy: Always reset ControlSerializer during IPA configure

 src/ipa/ipu3/ipu3.cpp                                         | 2 ++
 src/libcamera/ipa_manager.cpp                                 | 1 +
 .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl  | 4 ++++
 3 files changed, 7 insertions(+)